From 34db924fa7cfcc0c84103163ab18976a074f94ea Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Fri, 15 Aug 2014 17:39:00 +0000 Subject: [PATCH] Objective-C. Do not warn if user is using property-dox syntax to name a user provided setter name (as declared in @property attribute declaration). rdar://18022762 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@215736 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaExprObjC.cpp | 6 +++++- test/SemaObjC/property-user-setter.m | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/Sema/SemaExprObjC.cpp b/lib/Sema/SemaExprObjC.cpp index 0facca0391..39598b5a19 100644 --- a/lib/Sema/SemaExprObjC.cpp +++ b/lib/Sema/SemaExprObjC.cpp @@ -1708,11 +1708,15 @@ HandleExprPropertyRefExpr(const ObjCObjectPointerType *OPT, // name 'x'. if (Setter && Setter->isImplicit() && Setter->isPropertyAccessor() && !IFace->FindPropertyDeclaration(Member)) { - if (const ObjCPropertyDecl *PDecl = Setter->findPropertyDecl()) + if (const ObjCPropertyDecl *PDecl = Setter->findPropertyDecl()) { + // Do not warn if user is using property-dot syntax to make call to + // user named setter. + if (!(PDecl->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_setter)) Diag(MemberLoc, diag::warn_property_access_suggest) << MemberName << QualType(OPT, 0) << PDecl->getName() << FixItHint::CreateReplacement(MemberLoc, PDecl->getName()); + } } if (Getter || Setter) { diff --git a/test/SemaObjC/property-user-setter.m b/test/SemaObjC/property-user-setter.m index 5d2a3a21e1..7674c2b3a2 100644 --- a/test/SemaObjC/property-user-setter.m +++ b/test/SemaObjC/property-user-setter.m @@ -151,7 +151,7 @@ int main (void) { - (void) dealloc { - self.formatter = 0; // expected-warning {{property 'formatter' not found on object of type 'FMXBridgeFormatter *'; did you mean to access property cppFormatter?}} + self.formatter = 0; } @end -- 2.40.0