From 3423d0af7ca1e8cfd8ccc57c2a0cea333dc45192 Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Fri, 28 Oct 2016 08:24:51 -0600 Subject: [PATCH] Don't try to syntax check an unrecognized Defaults value in visudo. --- plugins/sudoers/defaults.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/plugins/sudoers/defaults.c b/plugins/sudoers/defaults.c index bab834388..cb6e16ff3 100644 --- a/plugins/sudoers/defaults.c +++ b/plugins/sudoers/defaults.c @@ -717,13 +717,14 @@ check_defaults(int what, bool quiet) if (!quiet) sudo_warnx(U_("unknown defaults entry `%s'"), def->var); rc = false; + } else { + /* Don't actually set the defaults value, just checking. */ + tmp = *cur; + memset(&tmp.sd_un, 0, sizeof(tmp.sd_un)); + if (!set_default_entry(&tmp, def->val, def->op, quiet, false)) + rc = false; + free_default(&tmp); } - /* Don't actually set the defaults value, just checking. */ - tmp = *cur; - memset(&tmp.sd_un, 0, sizeof(tmp.sd_un)); - if (!set_default_entry(&tmp, def->val, def->op, quiet, false)) - rc = false; - free_default(&tmp); } debug_return_bool(rc); } -- 2.40.0