From 33efe2f088ae40b5129fe4ab021912e80129e155 Mon Sep 17 00:00:00 2001 From: Richard Pennington Date: Tue, 23 Feb 2010 12:22:13 +0000 Subject: [PATCH] Retain attributes for K&R style parameter declarations. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@96941 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Parse/Parser.cpp | 9 +++++---- test/Parser/knr_parameter_attributes.c | 11 +++++++++++ 2 files changed, 16 insertions(+), 4 deletions(-) create mode 100644 test/Parser/knr_parameter_attributes.c diff --git a/lib/Parse/Parser.cpp b/lib/Parse/Parser.cpp index 30899c5ddd..24162373e0 100644 --- a/lib/Parse/Parser.cpp +++ b/lib/Parse/Parser.cpp @@ -743,10 +743,11 @@ void Parser::ParseKNRParamDeclarations(Declarator &D) { // Handle the full declarator list. while (1) { // If attributes are present, parse them. - llvm::OwningPtr AttrList; - if (Tok.is(tok::kw___attribute)) - // FIXME: attach attributes too. - AttrList.reset(ParseGNUAttributes()); + if (Tok.is(tok::kw___attribute)) { + SourceLocation Loc; + AttributeList *AttrList = ParseGNUAttributes(&Loc); + ParmDeclarator.AddAttributes(AttrList, Loc); + } // Ask the actions module to compute the type for this declarator. Action::DeclPtrTy Param = diff --git a/test/Parser/knr_parameter_attributes.c b/test/Parser/knr_parameter_attributes.c new file mode 100644 index 0000000000..fb975cbf33 --- /dev/null +++ b/test/Parser/knr_parameter_attributes.c @@ -0,0 +1,11 @@ +// RUN: %clang_cc1 -fsyntax-only -W -Wall -Werror -verify %s + +int f(int i __attribute__((__unused__))) +{ + return 0; +} +int g(i) + int i __attribute__((__unused__)); +{ + return 0; +} -- 2.40.0