From 33eb2decbffda82e82428d510330d1c97ead75d3 Mon Sep 17 00:00:00 2001 From: Stefan Eissing Date: Mon, 26 Oct 2015 12:19:52 +0000 Subject: [PATCH] lowering log level for common client connection issues git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1710584 13f79535-47bb-0310-9956-ffa450edef68 --- modules/http2/h2_conn.c | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/modules/http2/h2_conn.c b/modules/http2/h2_conn.c index 00decc723c..4cd29c9b38 100644 --- a/modules/http2/h2_conn.c +++ b/modules/http2/h2_conn.c @@ -293,21 +293,24 @@ apr_status_t h2_session_process(h2_session *session) break; case APR_EAGAIN: /* non-blocking read, nothing there */ break; - case APR_EBADF: /* connection is not there any more */ - case APR_EOF: - case APR_ECONNABORTED: - case APR_ECONNRESET: - case APR_TIMEUP: /* blocked read, timed out */ - ap_log_cerror( APLOG_MARK, APLOG_DEBUG, status, session->c, - "h2_session(%ld): reading", - session->id); - h2_session_abort(session, status, 0); - break; default: - ap_log_cerror( APLOG_MARK, APLOG_INFO, status, session->c, - APLOGNO(02950) - "h2_session(%ld): error reading, terminating", - session->id); + if (APR_STATUS_IS_ETIMEDOUT(status) + || APR_STATUS_IS_ECONNABORTED(status) + || APR_STATUS_IS_ECONNRESET(status) + || APR_STATUS_IS_EOF(status) + || APR_STATUS_IS_EBADF(status)) { + /* common status for a client that has left */ + ap_log_cerror( APLOG_MARK, APLOG_DEBUG, status, session->c, + "h2_session(%ld): terminating", + session->id); + } + else { + /* uncommon status, log on INFO so that we see this */ + ap_log_cerror( APLOG_MARK, APLOG_INFO, status, session->c, + APLOGNO(02950) + "h2_session(%ld): error reading, terminating", + session->id); + } h2_session_abort(session, status, 0); break; } -- 2.50.1