From 338f974b6e4f5d5d004d36d0d446289280d0c372 Mon Sep 17 00:00:00 2001 From: Kostya Serebryany Date: Sat, 17 Sep 2016 06:01:55 +0000 Subject: [PATCH] [libFuzzer] properly reset the guards when reseting the coverage. Also try to fix check-fuzzer on the bot git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@281814 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Fuzzer/FuzzerInternal.h | 3 +++ lib/Fuzzer/FuzzerTracePC.cpp | 8 ++++++++ lib/Fuzzer/test/trace-pc/CMakeLists.txt | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/Fuzzer/FuzzerInternal.h b/lib/Fuzzer/FuzzerInternal.h index 69b38abc26f..3cecd21ab46 100644 --- a/lib/Fuzzer/FuzzerInternal.h +++ b/lib/Fuzzer/FuzzerInternal.h @@ -380,6 +380,7 @@ class TracePC { NumNewPCs = 0; CounterMap.Reset(); TotalCoverageMap.Reset(); + ResetGuards(); } void PrintModuleInfo(); @@ -394,6 +395,8 @@ private: size_t NumNewPCs = 0; void AddNewPC(uintptr_t PC) { NewPCs[(NumNewPCs++) % kMaxNewPCs] = PC; } + void ResetGuards(); + struct Module { uint64_t *Start, *Stop; }; diff --git a/lib/Fuzzer/FuzzerTracePC.cpp b/lib/Fuzzer/FuzzerTracePC.cpp index 8fa9257c23b..dbc136a8cb2 100644 --- a/lib/Fuzzer/FuzzerTracePC.cpp +++ b/lib/Fuzzer/FuzzerTracePC.cpp @@ -34,6 +34,8 @@ void TracePC::HandleTrace(uint64_t *Guard, uintptr_t PC) { } if (Counter < 255) Value++; + else + Value |= kBit63; } else { Value |= kBit63; TotalCoverage++; @@ -60,6 +62,12 @@ void TracePC::PrintModuleInfo() { Printf("\n"); } +void TracePC::ResetGuards() { + for (size_t M = 0; M < NumModules; M++) + for (uint64_t *X = Modules[M].Start; X < Modules[M].Stop; X++) + *X = (*X >> 32) << 32; +} + void TracePC::FinalizeTrace() { if (UseCounters && TotalCoverage) { for (size_t M = 0; M < NumModules; M++) { diff --git a/lib/Fuzzer/test/trace-pc/CMakeLists.txt b/lib/Fuzzer/test/trace-pc/CMakeLists.txt index c4e4e9c29d4..27a8b0f91b7 100644 --- a/lib/Fuzzer/test/trace-pc/CMakeLists.txt +++ b/lib/Fuzzer/test/trace-pc/CMakeLists.txt @@ -36,4 +36,4 @@ set_target_properties(LLVMFuzzer-DSO1 PROPERTIES LIBRARY_OUTPUT_DIRECTORY set_target_properties(LLVMFuzzer-DSO2 PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib/Fuzzer/lib") -set(TestBinaries ${TestBinaries} LLVMFuzzer-DSOTest) +set(TestBinaries ${TestBinaries} LLVMFuzzer-DSOTest PARENT_SCOPE) -- 2.50.1