From 335f025090d6a3c1ce93e16659324e19d83b8b5f Mon Sep 17 00:00:00 2001 From: Rafael Auler Date: Thu, 31 Jan 2019 13:31:33 +0000 Subject: [PATCH] Revert "Support attribute used in member funcs of class templates" This reverts commit 352740: broke swift build git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@352748 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaTemplateInstantiateDecl.cpp | 14 -------------- ...member-function-implicit-instantiation.cpp | 19 ------------------- 2 files changed, 33 deletions(-) delete mode 100644 test/CodeGenCXX/attr-used-member-function-implicit-instantiation.cpp diff --git a/lib/Sema/SemaTemplateInstantiateDecl.cpp b/lib/Sema/SemaTemplateInstantiateDecl.cpp index 07533828df..883a73f226 100644 --- a/lib/Sema/SemaTemplateInstantiateDecl.cpp +++ b/lib/Sema/SemaTemplateInstantiateDecl.cpp @@ -2175,20 +2175,6 @@ TemplateDeclInstantiator::VisitCXXMethodDecl(CXXMethodDecl *D, Owner->addDecl(Method); } - // PR17480: Honor the used attribute to instantiate member function - // definitions - if (Method->hasAttr()) { - if (const auto *A = dyn_cast(Owner)) { - SourceLocation Loc; - if (const MemberSpecializationInfo *MSInfo = - A->getMemberSpecializationInfo()) - Loc = MSInfo->getPointOfInstantiation(); - else if (const auto *Spec = dyn_cast(A)) - Loc = Spec->getPointOfInstantiation(); - SemaRef.MarkFunctionReferenced(Loc, Method); - } - } - return Method; } diff --git a/test/CodeGenCXX/attr-used-member-function-implicit-instantiation.cpp b/test/CodeGenCXX/attr-used-member-function-implicit-instantiation.cpp deleted file mode 100644 index 7d2062f989..0000000000 --- a/test/CodeGenCXX/attr-used-member-function-implicit-instantiation.cpp +++ /dev/null @@ -1,19 +0,0 @@ -// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -o - %s | FileCheck %s - -// Check that PR17480 is fixed: __attribute__((used)) ignored in templated -// classes -namespace InstantiateUsedMemberDefinition { -template -struct S { - int __attribute__((used)) f() { - return 0; - } -}; - -void test() { - // Check that InstantiateUsedMemberDefinition::S::f() is defined - // as a result of the S class template implicit instantiation - // CHECK: define linkonce_odr i32 @_ZN31InstantiateUsedMemberDefinition1SIiE1fEv - S inst; -} -} // namespace InstantiateUsedMemberDefinition -- 2.40.0