From 3250e630a35d9703e99a4904373f77fc81227cc2 Mon Sep 17 00:00:00 2001 From: Antony Dovgal Date: Thu, 27 Jan 2005 14:39:21 +0000 Subject: [PATCH] fix leak in mysqli_fetch_array() when using invalid resulttype --- ext/mysqli/mysqli.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ext/mysqli/mysqli.c b/ext/mysqli/mysqli.c index 8d8560cacd..7b9aaf6641 100644 --- a/ext/mysqli/mysqli.c +++ b/ext/mysqli/mysqli.c @@ -623,6 +623,11 @@ void php_mysqli_fetch_into_hash(INTERNAL_FUNCTION_PARAMETERS, int override_flags MYSQLI_FETCH_RESOURCE(result, MYSQL_RES *, &mysql_result, "mysqli_result"); + if ((fetchtype & MYSQLI_BOTH) == 0) { + php_error_docref(NULL TSRMLS_CC, E_WARNING, "The result type should be either MYSQLI_NUM, MYSQLI_ASSOC or MYSQLI_BOTH"); + RETURN_FALSE; + } + if (!(row = mysql_fetch_row(result))) { RETURN_NULL(); } -- 2.50.1