From 31b1dc19986b157f2b47111922dbca6e8dfe395f Mon Sep 17 00:00:00 2001 From: thib Date: Mon, 28 Oct 2002 17:51:13 +0000 Subject: [PATCH] *** empty log message *** --- Makefile.in | 4 ++-- doc/en/changes.sgml | 29 +++++++++++++++++++++++++---- doc/en/fcron-doc.sgml | 4 ++-- doc/en/fcrondyn.1.sgml | 8 +------- doc/en/readme.sgml | 5 +++-- doc/en/relnotes.sgml | 4 ++-- doc/en/todo.sgml | 19 ++++++++----------- fcrontab.c | 6 +++--- option.h | 4 ++-- 9 files changed, 48 insertions(+), 35 deletions(-) diff --git a/Makefile.in b/Makefile.in index a712dbc..d26247b 100644 --- a/Makefile.in +++ b/Makefile.in @@ -4,7 +4,7 @@ # @configure_input@ -# $Id: Makefile.in,v 1.94 2002-10-06 17:15:58 thib Exp $ +# $Id: Makefile.in,v 1.95 2002-10-28 17:54:31 thib Exp $ # The following should not be edited manually (use configure options) # If you must do it, BEWARE : some of the following is also defined @@ -150,7 +150,7 @@ install-boot: install install-restart: install ifeq ($(DEBUG), 1) kill -TERM `pidof fcron` || exit 0 - /etc/rc.d/init.d/fcron start + /etc/init.d/fcron restart endif uninstall: diff --git a/doc/en/changes.sgml b/doc/en/changes.sgml index a9df62e..ea8e1ee 100644 --- a/doc/en/changes.sgml +++ b/doc/en/changes.sgml @@ -8,7 +8,7 @@ Foundation. A copy of the license is included in gfdl.sgml. --> - + Changes @@ -21,15 +21,36 @@ root for a standard user. This could make an inattentive superuser install a use runas(root) involontary. - Perf improvement : we use now a buffer in fcrontab while copying -an orig file (became necessary due to the use of O_SYNC) + Perf improvement : we now use buffers to write something to disk + (became necessary due to the use of O_SYNC). + + + The PID indicated by fcrondyn is now the pid of the job itself +(up to now, it was the one of the fcron process controlling the job). + + + Implemented functions kill (send a signal to a running job) +and renice (change the priority of a running job) in fcrondyn. + + + Added fcron's option -q to control the lavg and serial queue sizes. + + + + Added some timeouts in fcron for fcrondyn clients. bug fix : in 2.9.2, fcrontab and fcron did not set correctly some file modes. - code clean : use the same scheme for all struct types. + bug (introduced in 2.9.1) : when a job stops with an non-zero exit +status or because it has been signaled, send a mail to its owner to inform him +(in 2.9.1 and 2.9.2, the mail was sent, but contained nothing). + + + code clean : use the same scheme for all struct types, removed +some code redundancy (save to disk management). diff --git a/doc/en/fcron-doc.sgml b/doc/en/fcron-doc.sgml index 6e475d9..a0eed18 100644 --- a/doc/en/fcron-doc.sgml +++ b/doc/en/fcron-doc.sgml @@ -15,7 +15,7 @@ Foundation. A copy of the license is included in gfdl.sgml. --> - + @@ -61,7 +61,7 @@ license in ). This release (&version;) - as every version of the form x.y.z where y is an odd number -, is a development -release so it may contain more bugs (and uglier ones :)) ) than a stable +release, so it may contain more bugs (and uglier ones :)) ) than a stable release. diff --git a/doc/en/fcrondyn.1.sgml b/doc/en/fcrondyn.1.sgml index e4ec14e..ed36062 100644 --- a/doc/en/fcrondyn.1.sgml +++ b/doc/en/fcrondyn.1.sgml @@ -8,7 +8,7 @@ Foundation. A copy of the license is included in gfdl.sgml. --> - + @@ -254,12 +254,6 @@ job. jobid is the one given by PID The pid of the running job. - - This is currently not the pid of the job itself, - but the pid of the fcron process controlling it. However, - the pid of the job itself should be a number close to - that one (under linux at least). - diff --git a/doc/en/readme.sgml b/doc/en/readme.sgml index c0dc4bf..9a814db 100644 --- a/doc/en/readme.sgml +++ b/doc/en/readme.sgml @@ -8,7 +8,7 @@ Foundation. A copy of the license is included in gfdl.sgml. --> - + About fcron @@ -116,7 +116,8 @@ library. Compilation and installation - See the INSTALL file. + See the install file (either install.txt +or install.html). diff --git a/doc/en/relnotes.sgml b/doc/en/relnotes.sgml index 02f3d2e..db38896 100644 --- a/doc/en/relnotes.sgml +++ b/doc/en/relnotes.sgml @@ -8,7 +8,7 @@ Foundation. A copy of the license is included in gfdl.sgml. --> - + Release notes : &fcron; &version; @@ -19,7 +19,7 @@ expert would be appreciated (to audit the PAM code in fcron, and test it). You can disable PAM use in configure, using "--with-pam=no". - Many commands of &fcrondyn; are not implemented yet. In + Some commands of &fcrondyn; are not implemented yet. In particular, fcrondyn does not use PAM yet. diff --git a/doc/en/todo.sgml b/doc/en/todo.sgml index 49f5b25..2991b28 100644 --- a/doc/en/todo.sgml +++ b/doc/en/todo.sgml @@ -8,7 +8,7 @@ Foundation. A copy of the license is included in gfdl.sgml. --> - + Todo @@ -24,14 +24,10 @@ well. Help is welcome to catch this bug ! - bug fix (?) : "already running" bug (? - unconfirmed) - - - find a way to get user's job pid (not the fcron process - controlling it) (use pipe() ?) - - - Use (or remove from config.h.in) MAX_USER_CON & MAX_IDLE_TIME. + make fcron more robust concerning system crash, hardware failure, etc. +In particular, save files under a temporary name, check if everything's all right, +and if yes, replace the old file by renaming the temporary file (use rename() +or a direct save if rename() fails (EBUSY) ). Use directory notifications (?) (portable ?) (cf. dnotify) @@ -41,10 +37,11 @@ well. using PAM - not implemented in fcrondyn) - run one of this job, change its nice value, stop it... + implement more commands for fcrondyn, and make it more secure +and reliable - make fcrondyn more secure and reliable + For environment settings, make a var substitution. add a return code for jobs which would mean that they should diff --git a/fcrontab.c b/fcrontab.c index 928bca7..c00714e 100644 --- a/fcrontab.c +++ b/fcrontab.c @@ -22,7 +22,7 @@ * `LICENSE' that comes with the fcron source distribution. */ - /* $Id: fcrontab.c,v 1.62 2002-10-06 16:52:28 thib Exp $ */ + /* $Id: fcrontab.c,v 1.63 2002-10-28 17:51:13 thib Exp $ */ /* * The goal of this program is simple : giving a user interface to fcron @@ -47,7 +47,7 @@ #include "temp_file.h" #include "read_string.h" -char rcs_info[] = "$Id: fcrontab.c,v 1.62 2002-10-06 16:52:28 thib Exp $"; +char rcs_info[] = "$Id: fcrontab.c,v 1.63 2002-10-28 17:51:13 thib Exp $"; void info(void); void usage(void); @@ -583,7 +583,7 @@ install_stdin(void) int tmp_fd = 0; FILE *tmp_file = NULL; char *tmp_str = NULL; - register int c; + int c; short return_val = EXIT_OK; tmp_fd = temp_file(&tmp_str); diff --git a/option.h b/option.h index 4c40b84..7f6c63b 100644 --- a/option.h +++ b/option.h @@ -21,7 +21,7 @@ * `LICENSE' that comes with the fcron source distribution. */ - /* $Id: option.h,v 1.21 2002-02-25 18:46:37 thib Exp $ */ + /* $Id: option.h,v 1.22 2002-10-28 17:56:43 thib Exp $ */ /* This has been inspired from bitstring(3) : here is the original copyright : */ @@ -67,7 +67,7 @@ 4 should we run this job at fcron startup if it should have been executed during system down? 5 should this job be run serially ? - 6 is this job should be run serially only once (for bootrun) ? + 6 should this job be run serially only once (for bootrun) ? 7 does the output have to be mailed to user ? 8 does the output (even if zero-length) must be mailed to user ? 9 if time of execution is exceeded, exec the lavg job or not ? -- 2.40.0