From 318b8f35fe6c56c2c2792192ccdeb2b47eff81e4 Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Wed, 12 Jan 2011 18:45:27 +0000 Subject: [PATCH] Issue #10822: Fix test_posix:test_getgroups failure under Solaris. Patch by Ross Lagerwall. --- Lib/test/test_posix.py | 5 ++++- Misc/NEWS | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py index f9f9fcec6a..45b3afc72d 100644 --- a/Lib/test/test_posix.py +++ b/Lib/test/test_posix.py @@ -373,6 +373,7 @@ class PosixTester(unittest.TestCase): os.chdir(curdir) support.rmtree(base_path) + @unittest.skipUnless(hasattr(os, 'getegid'), "test needs os.getegid()") def test_getgroups(self): with os.popen('id -G') as idg: groups = idg.read().strip() @@ -382,9 +383,11 @@ class PosixTester(unittest.TestCase): # 'id -G' and 'os.getgroups()' should return the same # groups, ignoring order and duplicates. + # #10822 - it is implementation defined whether posix.getgroups() + # includes the effective gid so we include it anyway, since id -G does self.assertEqual( set([int(x) for x in groups.split()]), - set(posix.getgroups())) + set(posix.getgroups() + [posix.getegid()])) class PosixGroupsTester(unittest.TestCase): diff --git a/Misc/NEWS b/Misc/NEWS index ee69f507db..406c8d04ae 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -223,6 +223,9 @@ Tools/Demos Tests ----- +- Issue #10822: Fix test_posix:test_getgroups failure under Solaris. Patch + by Ross Lagerwall. + - Make the --coverage flag work for test.regrtest. - Issue #1677694: Refactor and improve test_timeout. Original patch by -- 2.50.1