From 2ff9d0318c65a7fbc3977c768a59375ff35e7d70 Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Fri, 16 Mar 2012 12:00:32 -0400 Subject: [PATCH] Remove bogus optimization that could lead to a double free of the group list. --- plugins/sudoers/set_perms.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/plugins/sudoers/set_perms.c b/plugins/sudoers/set_perms.c index 50d0aaba9..dcedba648 100644 --- a/plugins/sudoers/set_perms.c +++ b/plugins/sudoers/set_perms.c @@ -132,8 +132,6 @@ set_perms(int perm) goto bad; } ostate = &perm_stack[perm_stack_depth - 1]; - if (memcmp(state, ostate, sizeof(*state)) == 0) - goto done; } switch (perm) { @@ -449,8 +447,6 @@ set_perms(int perm) goto bad; } ostate = &perm_stack[perm_stack_depth - 1]; - if (memcmp(state, ostate, sizeof(*state)) == 0) - goto done; } switch (perm) { @@ -816,8 +812,6 @@ set_perms(int perm) goto bad; } ostate = &perm_stack[perm_stack_depth - 1]; - if (memcmp(state, ostate, sizeof(*state)) == 0) - goto done; } switch (perm) { @@ -1105,8 +1099,6 @@ set_perms(int perm) goto bad; } ostate = &perm_stack[perm_stack_depth - 1]; - if (memcmp(state, ostate, sizeof(*state)) == 0) - goto done; } /* @@ -1390,8 +1382,6 @@ set_perms(int perm) goto bad; } ostate = &perm_stack[perm_stack_depth - 1]; - if (memcmp(state, ostate, sizeof(*state)) == 0) - goto done; } switch (perm) { -- 2.50.1