From 2adf58cfcf9a2e4b55a775fcbd3ccc5dd16ec979 Mon Sep 17 00:00:00 2001 From: Felipe Pena Date: Wed, 23 Mar 2011 01:22:18 +0000 Subject: [PATCH] - Fixed bug #54283 (new DatePeriod(NULL) causes crash) --- ext/date/php_date.c | 2 +- ext/date/tests/bug54283.phpt | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 ext/date/tests/bug54283.phpt diff --git a/ext/date/php_date.c b/ext/date/php_date.c index 56c6f8e976..1930e88abd 100644 --- a/ext/date/php_date.c +++ b/ext/date/php_date.c @@ -3762,7 +3762,7 @@ PHP_METHOD(DatePeriod, __construct) dpobj = zend_object_store_get_object(getThis() TSRMLS_CC); dpobj->current = NULL; - if (isostr_len) { + if (isostr) { date_period_initialize(&(dpobj->start), &(dpobj->end), &(dpobj->interval), &recurrences, isostr, isostr_len TSRMLS_CC); if (dpobj->start == NULL) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "The ISO interval '%s' did not contain a start date.", isostr); diff --git a/ext/date/tests/bug54283.phpt b/ext/date/tests/bug54283.phpt new file mode 100644 index 0000000000..780d0fa762 --- /dev/null +++ b/ext/date/tests/bug54283.phpt @@ -0,0 +1,14 @@ +--TEST-- +Bug #54283 (new DatePeriod(NULL) causes crash) +--FILE-- +getMessage()); +} + +?> +--EXPECTF-- +string(51) "DatePeriod::__construct(): Unknown or bad format ()" -- 2.50.1