From 28f6ee5f9ef96dc5f9d4a60594484ea16b48cd10 Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Tue, 22 Jul 2014 14:53:15 -0600 Subject: [PATCH] Fix NULL deref if base64_decode returns -1. --- plugins/sudoers/ldap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/sudoers/ldap.c b/plugins/sudoers/ldap.c index cd8398ef4..1c0990652 100644 --- a/plugins/sudoers/ldap.c +++ b/plugins/sudoers/ldap.c @@ -1403,8 +1403,9 @@ sudo_ldap_decode_secret(const char *secret) if (len == (size_t)-1) { free(result); result = NULL; + } else { + result[len] = '\0'; } - result[len] = '\0'; } debug_return_str((char *)result); } -- 2.50.1