From 28ee1c157a78c5d512a8e4894c6946fb3b2a9f4c Mon Sep 17 00:00:00 2001 From: Richard Smith Date: Thu, 14 Jun 2018 20:03:22 +0000 Subject: [PATCH] [c++17] If a class inherits virtual functions from a base class, it is not an aggregtae. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@334763 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/AST/DeclCXX.cpp | 6 +++++- test/CXX/dcl.decl/dcl.init/dcl.init.aggr/p1.cpp | 5 +++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/AST/DeclCXX.cpp b/lib/AST/DeclCXX.cpp index b3607caef6..076e6376d1 100644 --- a/lib/AST/DeclCXX.cpp +++ b/lib/AST/DeclCXX.cpp @@ -259,9 +259,13 @@ CXXRecordDecl::setBases(CXXBaseSpecifier const * const *Bases, // C++ [class.virtual]p1: // A class that declares or inherits a virtual function is called a // polymorphic class. - if (BaseClassDecl->isPolymorphic()) + if (BaseClassDecl->isPolymorphic()) { data().Polymorphic = true; + // An aggregate is a class with [...] no virtual functions. + data().Aggregate = false; + } + // C++0x [class]p7: // A standard-layout class is a class that: [...] // -- has no non-standard-layout base classes diff --git a/test/CXX/dcl.decl/dcl.init/dcl.init.aggr/p1.cpp b/test/CXX/dcl.decl/dcl.init/dcl.init.aggr/p1.cpp index f4f73a5af8..e9e9ce57fa 100644 --- a/test/CXX/dcl.decl/dcl.init/dcl.init.aggr/p1.cpp +++ b/test/CXX/dcl.decl/dcl.init/dcl.init.aggr/p1.cpp @@ -111,6 +111,11 @@ struct NonAggr6 { // expected-note 3 {{candidate constructor}} }; NonAggr6 na6 = { 42 }; // expected-error {{no matching constructor for initialization of 'NonAggr6'}} +struct NonAggr7 : NonAggr6 { // expected-note 3 {{candidate constructor}} + int n; +}; +NonAggr7 na7 = {{}, 42}; // expected-error {{no matching constructor for initialization of 'NonAggr7'}} + struct DefaultedAggr { int n; -- 2.50.1