From 27283bbc6f405522a0caf744ec5c6b6204cd975a Mon Sep 17 00:00:00 2001 From: Jim Warner Date: Mon, 28 Sep 2015 00:00:00 -0500 Subject: [PATCH] library: strengthen sort order parameter checks The way that the passed sort order was validated would allow the invalid 0 to fall between the sofa cushions. So this patch will simply close that former oversight. Signed-off-by: Jim Warner --- proc/pids.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proc/pids.c b/proc/pids.c index 6be88d81..a3229a15 100644 --- a/proc/pids.c +++ b/proc/pids.c @@ -1389,7 +1389,7 @@ PROCPS_EXPORT struct pids_stack **procps_pids_stacks_sort ( // a pids_item is currently unsigned, but we'll protect our future if (sort < 0 || sort > PROCPS_PIDS_noop) return NULL; - if (order < -1 || order > +1) + if (order != PROCPS_SORT_ASCEND && order != PROCPS_SORT_DESCEND) return NULL; if (numstacked < 2) return stacks; -- 2.40.0