From 2712da8b64b4e399a2666cce2c25329f4f834f2d Mon Sep 17 00:00:00 2001 From: Magnus Hagander Date: Wed, 31 May 2017 20:57:25 +0200 Subject: [PATCH] Generate pg_basebackup temporary slot name using backend pid Using the client pid can easily be non-unique when used on different hosts. Using the backend pid should be guaranteed unique, since the temporary slot gets removed when the client disconnects so it will be gone even if the pid is renewed. Reported by Ludovic Vaugeois-Pepin --- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c index 432c282b52..3d6fce2e34 100644 --- a/src/bin/pg_basebackup/pg_basebackup.c +++ b/src/bin/pg_basebackup/pg_basebackup.c @@ -493,7 +493,7 @@ LogStreamerMain(logstreamer_param *param) stream.replication_slot = replication_slot; stream.temp_slot = param->temp_slot; if (stream.temp_slot && !stream.replication_slot) - stream.replication_slot = psprintf("pg_basebackup_%d", (int) getpid()); + stream.replication_slot = psprintf("pg_basebackup_%d", (int) PQbackendPID(param->bgconn)); if (format == 'p') stream.walmethod = CreateWalDirectoryMethod(param->xlog, 0, do_sync); -- 2.40.0