From 26fe0d56912e42c2b16a61b2480e19ba569aee98 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Sat, 10 Sep 2016 14:27:30 +0200 Subject: [PATCH] patch 7.4.2359 Problem: Memory leak in timer_start(). Solution: Check the right field to be NULL. --- src/evalfunc.c | 2 +- src/testdir/test_timers.vim | 8 ++++---- src/version.c | 2 ++ 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/evalfunc.c b/src/evalfunc.c index 906fa39af..7dd5c2a4d 100644 --- a/src/evalfunc.c +++ b/src/evalfunc.c @@ -12429,7 +12429,7 @@ f_timer_start(typval_T *argvars, typval_T *rettv) free_callback(callback, partial); else { - if (timer->tr_partial == NULL) + if (partial == NULL) timer->tr_callback = vim_strsave(callback); else /* pointer into the partial */ diff --git a/src/testdir/test_timers.vim b/src/testdir/test_timers.vim index 07c6876ee..ebc666580 100644 --- a/src/testdir/test_timers.vim +++ b/src/testdir/test_timers.vim @@ -48,12 +48,12 @@ endfunc func Test_with_partial_callback() let g:val = 0 - let s:meow = {} - function s:meow.bite(...) - let g:val += 1 + let meow = {'one': 1} + function meow.bite(...) + let g:val += self.one endfunction - call timer_start(50, s:meow.bite) + call timer_start(50, meow.bite) let slept = WaitFor('g:val == 1') call assert_equal(1, g:val) if has('reltime') diff --git a/src/version.c b/src/version.c index 0767d4afd..65757ab9d 100644 --- a/src/version.c +++ b/src/version.c @@ -763,6 +763,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 2359, /**/ 2358, /**/ -- 2.50.1