From 26561d25d67c12a21fdb7a791ffb3b9f21b691e7 Mon Sep 17 00:00:00 2001 From: "Emden R. Gansner" Date: Fri, 13 Sep 2013 10:45:12 -0400 Subject: [PATCH] Remove aspect attribute until the implementation problems can be fixed --- doc/info/attrs.html | 27 --------------------------- doc/infosrc/attrs | 36 ++++++++++++++++++------------------ doc/infosrc/types | 8 ++++---- lib/dotgen/aspect.c | 5 +++++ 4 files changed, 27 insertions(+), 49 deletions(-) diff --git a/doc/info/attrs.html b/doc/info/attrs.html index 2d10f29ed..9d00f49a8 100644 --- a/doc/info/attrs.html +++ b/doc/info/attrs.html @@ -96,9 +96,6 @@ This field indicates which graph component uses the attribute. arrowtail EarrowType normal - aspect -GaspectType -dot only bb Grect write only @@ -573,25 +570,6 @@ This field indicates which graph component uses the attribute. is "back" or "both". See the limitation. -
aspect -
Target aspect ratio (width of the layout divided by the height) - of the graph drawing. If unset, dot minimizes the total edge length. - For certain graphs, like those with large fan-in or fan-out, this can - lead to very wide layouts. Setting aspect will cause dot to try - to adjust the layout to get an aspect ratio close to that specified - by aspect. -

- By default, dot will do 5 passes attempting to achieve the desired - aspect ratio. For certain graphs, more passes will be needed to get - close enough. The aspect attribute can also be used to - specify the maximum number of passes to try. -

- At present, there is no mechanism for widening a very tall layout. - Also, the algorithm doesn't handle clusters, nor disconnected graphs. - For the latter case, one can split the pipeline
- ccomps -x | dot | gvpack | neato -n2 - to get a similar effect. -

bb
Bounding box of drawing in points. @@ -2047,11 +2025,6 @@ enclosed in the parentheses, (...)+ indicates 1 or more, and (ediamond, open, halfopen, empty, invempty). -
aspectType -

An aspect ratio, double, followed optionally by a ',' and a maximum pass - count. If the aspect ratio is given, but no maximum pass count, the - latter defaults to 5. -

clusterMode
"local","global","none" diff --git a/doc/infosrc/attrs b/doc/infosrc/attrs index f6a775e97..0850a4612 100644 --- a/doc/infosrc/attrs +++ b/doc/infosrc/attrs @@ -92,24 +92,24 @@ Style of arrowhead on the tail node of an edge. This will only appear if the dir attribute is "back" or "both". See the limitation. -:aspect:G:aspectType; dot -Target aspect ratio (width of the layout divided by the height) -of the graph drawing. If unset, dot minimizes the total edge length. -For certain graphs, like those with large fan-in or fan-out, this can -lead to very wide layouts. Setting aspect will cause dot to try -to adjust the layout to get an aspect ratio close to that specified -by aspect. -

-By default, dot will do 5 passes attempting to achieve the desired -aspect ratio. For certain graphs, more passes will be needed to get -close enough. The aspect attribute can also be used to -specify the maximum number of passes to try. -

-At present, there is no mechanism for widening a very tall layout. -Also, the algorithm doesn't handle clusters, nor disconnected graphs. -For the latter case, one can split the pipeline
-ccomps -x | dot | gvpack | neato -n2 -to get a similar effect. +#:aspect:G:aspectType; dot +#Target aspect ratio (width of the layout divided by the height) +#of the graph drawing. If unset, dot minimizes the total edge length. +#For certain graphs, like those with large fan-in or fan-out, this can +#lead to very wide layouts. Setting aspect will cause dot to try +#to adjust the layout to get an aspect ratio close to that specified +#by aspect. +##

+##By default, dot will do 5 passes attempting to achieve the desired +#aspect ratio. For certain graphs, more passes will be needed to get +#close enough. The aspect attribute can also be used to +#specify the maximum number of passes to try. +#

+#At present, there is no mechanism for widening a very tall layout. +#Also, the algorithm doesn't handle clusters, nor disconnected graphs. +#For the latter case, one can split the pipeline
+#ccomps -x | dot | gvpack | neato -n2 +#to get a similar effect. :bb:G:rect; write Bounding box of drawing in points. :bgcolor:GC:color/colorList:; diff --git a/doc/infosrc/types b/doc/infosrc/types index fe0dc6b9e..db94d2c82 100644 --- a/doc/infosrc/types +++ b/doc/infosrc/types @@ -9,10 +9,10 @@

A double with an optional prefix '+'. :addPoint

A point with an optional prefix '+'. -:aspectType -

An aspect ratio, double, followed optionally by a ',' and a maximum pass -count. If the aspect ratio is given, but no maximum pass count, the -latter defaults to 5. +#:aspectType +#

An aspect ratio, double, followed optionally by a ',' and a maximum pass +#count. If the aspect ratio is given, but no maximum pass count, the +#latter defaults to 5. :arrowType
"normal" diff --git a/lib/dotgen/aspect.c b/lib/dotgen/aspect.c index c55533ea6..42cfa20fc 100644 --- a/lib/dotgen/aspect.c +++ b/lib/dotgen/aspect.c @@ -1988,6 +1988,11 @@ setAspect (Agraph_t * g, aspect_t* adata) adata->badGraph = 0; return NULL; } + agerr (AGWARN, "the aspect attribute has been disabled due to implementation flaws - attribute ignored.\n"); + + adata->nextIter = 0; + adata->badGraph = 0; + return NULL; if (rv < MIN_AR) rv = MIN_AR; else if (rv > MAX_AR) rv = MAX_AR; -- 2.40.0