From 264c1f8ec895952466eab59b84b8b06801e721fa Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Thu, 19 Nov 2009 03:14:00 +0000 Subject: [PATCH] The sub-statement of a case statement is not an unevaluated context! git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@89303 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/TreeTransform.h | 23 +++++++++++++---------- test/SemaTemplate/instantiate-case.cpp | 21 +++++++++++++++++++++ 2 files changed, 34 insertions(+), 10 deletions(-) create mode 100644 test/SemaTemplate/instantiate-case.cpp diff --git a/lib/Sema/TreeTransform.h b/lib/Sema/TreeTransform.h index 2bee32aa0f..ca680c279b 100644 --- a/lib/Sema/TreeTransform.h +++ b/lib/Sema/TreeTransform.h @@ -3037,18 +3037,21 @@ TreeTransform::TransformCompoundStmt(CompoundStmt *S, template Sema::OwningStmtResult TreeTransform::TransformCaseStmt(CaseStmt *S) { - // The case value expressions are not potentially evaluated. - EnterExpressionEvaluationContext Unevaluated(SemaRef, Action::Unevaluated); + OwningExprResult LHS(SemaRef), RHS(SemaRef); + { + // The case value expressions are not potentially evaluated. + EnterExpressionEvaluationContext Unevaluated(SemaRef, Action::Unevaluated); - // Transform the left-hand case value. - OwningExprResult LHS = getDerived().TransformExpr(S->getLHS()); - if (LHS.isInvalid()) - return SemaRef.StmtError(); + // Transform the left-hand case value. + LHS = getDerived().TransformExpr(S->getLHS()); + if (LHS.isInvalid()) + return SemaRef.StmtError(); - // Transform the right-hand case value (for the GNU case-range extension). - OwningExprResult RHS = getDerived().TransformExpr(S->getRHS()); - if (RHS.isInvalid()) - return SemaRef.StmtError(); + // Transform the right-hand case value (for the GNU case-range extension). + RHS = getDerived().TransformExpr(S->getRHS()); + if (RHS.isInvalid()) + return SemaRef.StmtError(); + } // Build the case statement. // Case statements are always rebuilt so that they will attached to their diff --git a/test/SemaTemplate/instantiate-case.cpp b/test/SemaTemplate/instantiate-case.cpp new file mode 100644 index 0000000000..bed39d7ffb --- /dev/null +++ b/test/SemaTemplate/instantiate-case.cpp @@ -0,0 +1,21 @@ +// RUN: clang-cc -fsyntax-only -verify %s + +template +static int alpha(T c) +{ + return *c; // expected-error{{indirection requires pointer operand}} +} + +template +static void +_shexp_match() +{ + switch(1) { + case 1: + alpha(1); // expected-note{{instantiation of function template}} + } +} +int main() { + _shexp_match(); // expected-note{{instantiation of function template}} + return 0; +} -- 2.40.0