From 25d389789c59a52a31770f7c50ce9e02a8909190 Mon Sep 17 00:00:00 2001 From: Zackery Spytz Date: Wed, 5 Dec 2018 11:29:20 -0700 Subject: [PATCH] bpo-34987: Fix a possible null pointer dereference in _pickle.c's save_reduce(). (GH-9886) --- Modules/_pickle.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Modules/_pickle.c b/Modules/_pickle.c index 39f8b750ed..c4fe349187 100644 --- a/Modules/_pickle.c +++ b/Modules/_pickle.c @@ -3840,7 +3840,10 @@ save_reduce(PicklerObject *self, PyObject *args, PyObject *obj) if (obj != NULL) { obj_class = get_class(obj); - p = obj_class != cls; /* true iff a problem */ + if (obj_class == NULL) { + return -1; + } + p = obj_class != cls; Py_DECREF(obj_class); if (p) { PyErr_SetString(st->PicklingError, "args[0] from " -- 2.40.0