From 25b26ebdebe46bb4576247e0c64d1c11410a8e9d Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Mon, 18 Oct 2010 22:49:46 +0000 Subject: [PATCH] Driver: Reject -fasm-blocks except on X86 (where we just ignore it, since passing it is very prevalent in some circles). git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@116761 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/Basic/DiagnosticDriverKinds.td | 2 ++ include/clang/Driver/Options.td | 5 ++++- lib/Driver/Tools.cpp | 14 +++++++++++++- 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/include/clang/Basic/DiagnosticDriverKinds.td b/include/clang/Basic/DiagnosticDriverKinds.td index dd11b70014..52b69bab76 100644 --- a/include/clang/Basic/DiagnosticDriverKinds.td +++ b/include/clang/Basic/DiagnosticDriverKinds.td @@ -53,6 +53,8 @@ def err_drv_no_ast_support : Error< "'%0': unable to use AST files with this tool">; def err_drv_clang_unsupported : Error< "the clang compiler does not support '%0'">; +def err_drv_clang_unsupported_per_platform : Error< + "the clang compiler does not support '%0' on this platform">; def err_drv_clang_unsupported_opt_cxx_darwin_i386 : Error< "the clang compiler does not support '%0' for C++ on Darwin/i386">; def err_drv_command_failed : Error< diff --git a/include/clang/Driver/Options.td b/include/clang/Driver/Options.td index fea77725a6..b029b6e257 100644 --- a/include/clang/Driver/Options.td +++ b/include/clang/Driver/Options.td @@ -237,7 +237,10 @@ def faccess_control : Flag<"-faccess-control">, Group; def fallow_unsupported : Flag<"-fallow-unsupported">, Group; def fapple_kext : Flag<"-fapple-kext">, Group; def fasm : Flag<"-fasm">, Group; -def fasm_blocks : Flag<"-fasm-blocks">, Group; + +def fasm_blocks : Flag<"-fasm-blocks">, Group; +def fno_asm_blocks : Flag<"-fno-asm-blocks">, Group; + def fassume_sane_operator_new : Flag<"-fassume-sane-operator-new">, Group; def fastcp : Flag<"-fastcp">, Group; def fastf : Flag<"-fastf">, Group; diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp index 6e221b4c83..7924a034df 100644 --- a/lib/Driver/Tools.cpp +++ b/lib/Driver/Tools.cpp @@ -1469,6 +1469,18 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, options::OPT_fno_spell_checking)) CmdArgs.push_back("-fno-spell-checking"); + + // -fasm-blocks is disallowed except on X86, where we just ignore it. + if (Args.hasFlag(options::OPT_fasm_blocks, options::OPT_fno_asm_blocks, + false)) { + if (getToolChain().getTriple().getArch() != llvm::Triple::x86 && + getToolChain().getTriple().getArch() != llvm::Triple::x86_64) + D.Diag(clang::diag::err_drv_clang_unsupported_per_platform) + << "-fasm-blocks"; + } + + // -fasm-blocks is disallowed except on X86, where we just ignore it. + if (Arg *A = Args.getLastArg(options::OPT_fshow_overloads_EQ)) A->render(Args, CmdArgs); @@ -1577,7 +1589,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, (*it)->claim(); D.Diag(clang::diag::warn_drv_clang_unsupported) << (*it)->getAsString(Args); } - + // Claim some arguments which clang supports automatically. // -fpch-preprocess is used with gcc to add a special marker in the output to -- 2.40.0