From 255c269f35928a8194fb591656c67ec4ebd846eb Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Thu, 13 Jan 2011 17:44:36 +0000 Subject: [PATCH] When your comments and your code are out-of-sync, the test case is wrong. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@123379 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/Mangle.cpp | 2 +- test/CodeGenCXX/mangle-variadic-templates.cpp | 20 +++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/lib/CodeGen/Mangle.cpp b/lib/CodeGen/Mangle.cpp index 0dfa0520af..b8ae1e7e41 100644 --- a/lib/CodeGen/Mangle.cpp +++ b/lib/CodeGen/Mangle.cpp @@ -1477,7 +1477,7 @@ void CXXNameMangler::mangleType(const DependentSizedExtVectorType *T) { void CXXNameMangler::mangleType(const PackExpansionType *T) { // ::= Dp # pack expansion (C++0x) - Out << "sp"; + Out << "Dp"; mangleType(T->getPattern()); } diff --git a/test/CodeGenCXX/mangle-variadic-templates.cpp b/test/CodeGenCXX/mangle-variadic-templates.cpp index 0167726b0d..a987b49a12 100644 --- a/test/CodeGenCXX/mangle-variadic-templates.cpp +++ b/test/CodeGenCXX/mangle-variadic-templates.cpp @@ -9,13 +9,13 @@ template struct tuple { }; template struct int_tuple { }; template class ...Templates> struct template_tuple { }; -// CHECK: define weak_odr void @_Z2f0IJEEv1XIXsZT_EJspRT_EE +// CHECK: define weak_odr void @_Z2f0IJEEv1XIXsZT_EJDpRT_EE template void f0(X) { } template void f0(X<0>); -// CHECK: define weak_odr void @_Z2f0IJifdEEv1XIXsZT_EJspRT_EE +// CHECK: define weak_odr void @_Z2f0IJifdEEv1XIXsZT_EJDpRT_EE template void f0(X<3, int&, float&, double&>); // Mangling for template argument packs @@ -29,30 +29,30 @@ template void f1(); // Mangling function parameter packs template void f2(Types...) {} -// CHECK: define weak_odr void @_Z2f2IJEEvspT_ +// CHECK: define weak_odr void @_Z2f2IJEEvDpT_ template void f2<>(); -// CHECK: define weak_odr void @_Z2f2IJiEEvspT_ +// CHECK: define weak_odr void @_Z2f2IJiEEvDpT_ template void f2(int); -// CHECK: define weak_odr void @_Z2f2IJifEEvspT_ +// CHECK: define weak_odr void @_Z2f2IJifEEvDpT_ template void f2(int, float); // Mangling non-trivial function parameter packs template void f3(const Types *...) {} -// CHECK: define weak_odr void @_Z2f3IJEEvspPKT_ +// CHECK: define weak_odr void @_Z2f3IJEEvDpPKT_ template void f3<>(); -// CHECK: define weak_odr void @_Z2f3IJiEEvspPKT_ +// CHECK: define weak_odr void @_Z2f3IJiEEvDpPKT_ template void f3(const int*); -// CHECK: define weak_odr void @_Z2f3IJifEEvspPKT_ +// CHECK: define weak_odr void @_Z2f3IJifEEvDpPKT_ template void f3(const int*, const float*); // Mangling of type pack expansions in a template argument template tuple f4() {} -// CHECK: define weak_odr void @_Z2f4IJifdEE5tupleIJspT_EEv +// CHECK: define weak_odr void @_Z2f4IJifdEE5tupleIJDpT_EEv template tuple f4(); // Mangling of type pack expansions in a function type template identity f5() {} -// CHECK: define weak_odr void @_Z2f5IiJifdEE8identityIFT_spT0_EEv +// CHECK: define weak_odr void @_Z2f5IiJifdEE8identityIFT_DpT0_EEv template identity f5(); // Mangling of non-type template argument expansions -- 2.40.0