From 253e7fa90caf3cfc5314f47bac0fd9d98cd9e651 Mon Sep 17 00:00:00 2001 From: Azat Khuzhin Date: Tue, 6 Dec 2016 12:08:32 +0300 Subject: [PATCH] util-internal: fix __func__ redefinition (netbsd) ==> netbsd: In file included from ../listener.c:57:0: ==> netbsd: ../util-internal.h:58:0: warning: "__func__" redefined [enabled by default] ==> netbsd: #define __func__ EVENT____func__ ==> netbsd: ^ ==> netbsd: In file included from /usr/include/amd64/types.h:39:0, ==> netbsd: from /usr/include/sys/types.h:45, ==> netbsd: from ../listener.c:30: ==> netbsd: /usr/include/sys/cdefs.h:394:0: note: this is the location of the previous definition ==> netbsd: #define __func__ __PRETTY_FUNCTION__ --- event_rpcgen.py | 2 +- sample/signal-test.c | 6 +----- test/regress_main.c | 4 ---- test/test-closed.c | 4 ---- test/test-eof.c | 4 ---- test/test-weof.c | 5 +---- util-internal.h | 2 +- 7 files changed, 4 insertions(+), 23 deletions(-) diff --git a/event_rpcgen.py b/event_rpcgen.py index c5375656..9baf7302 100755 --- a/event_rpcgen.py +++ b/event_rpcgen.py @@ -1585,7 +1585,7 @@ class CCodeGenerator: '#include \n' '#include \n' '#include \n\n' - '#ifdef EVENT____func__\n' + '#if defined(EVENT____func__) && !defined(__func__)\n' '#define __func__ EVENT____func__\n' '#endif\n\n' ) diff --git a/sample/signal-test.c b/sample/signal-test.c index 6249f879..18668350 100644 --- a/sample/signal-test.c +++ b/sample/signal-test.c @@ -26,10 +26,6 @@ #include -#ifdef EVENT____func__ -#define __func__ EVENT____func__ -#endif - int called = 0; static void @@ -37,7 +33,7 @@ signal_cb(evutil_socket_t fd, short event, void *arg) { struct event *signal = arg; - printf("%s: got signal %d\n", __func__, event_get_signal(signal)); + printf("signal_cb: got signal %d\n", event_get_signal(signal)); if (called >= 2) event_del(signal); diff --git a/test/regress_main.c b/test/regress_main.c index 6d045bb8..44e29111 100644 --- a/test/regress_main.c +++ b/test/regress_main.c @@ -43,10 +43,6 @@ #include "event2/event-config.h" -#ifdef EVENT____func__ -#define __func__ EVENT____func__ -#endif - #if 0 #include #include diff --git a/test/test-closed.c b/test/test-closed.c index 47a56fa8..1dd98859 100644 --- a/test/test-closed.c +++ b/test/test-closed.c @@ -49,10 +49,6 @@ #include #include -#ifdef EVENT____func__ -#define __func__ EVENT____func__ -#endif - struct timeval timeout = {3, 0}; static void diff --git a/test/test-eof.c b/test/test-eof.c index 61169b14..284ead78 100644 --- a/test/test-eof.c +++ b/test/test-eof.c @@ -49,10 +49,6 @@ #include #include -#ifdef EVENT____func__ -#define __func__ EVENT____func__ -#endif - int test_okay = 1; int called = 0; struct timeval timeout = {60, 0}; diff --git a/test/test-weof.c b/test/test-weof.c index c379f287..52c7afbd 100644 --- a/test/test-weof.c +++ b/test/test-weof.c @@ -24,6 +24,7 @@ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#include "../util-internal.h" #include "event2/event-config.h" #ifdef _WIN32 @@ -51,10 +52,6 @@ #include "event2/event_compat.h" #include "event2/util.h" -#ifdef EVENT____func__ -#define __func__ EVENT____func__ -#endif - evutil_socket_t pair[2]; int test_okay = 1; int called = 0; diff --git a/util-internal.h b/util-internal.h index b851e2ae..38d0f595 100644 --- a/util-internal.h +++ b/util-internal.h @@ -54,7 +54,7 @@ extern "C" { #ifdef EVENT__inline #define inline EVENT__inline #endif -#ifdef EVENT____func__ +#if defined(EVENT____func__) && !defined(__func__) #define __func__ EVENT____func__ #endif -- 2.40.0