From 24eee37fed3faa1791753e246d9b4bb7847bb8a5 Mon Sep 17 00:00:00 2001 From: Sterling Hughes Date: Wed, 21 May 2003 17:44:08 +0000 Subject: [PATCH] seems there is only the stupid way to be stupid (implode copying array elements) at least we check for IS_STRING, which should clear this up 90% of the time --- ext/standard/string.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ext/standard/string.c b/ext/standard/string.c index 5fac07cf70..8be51df6fa 100644 --- a/ext/standard/string.c +++ b/ext/standard/string.c @@ -837,12 +837,8 @@ PHPAPI void php_implode(zval *delim, zval *arr, zval *return_value) while (zend_hash_get_current_data_ex(Z_ARRVAL_P(arr), (void **) &tmp, &pos) == SUCCESS) { if ((*tmp)->type != IS_STRING) { - if (PZVAL_IS_REF(*tmp)) { - SEPARATE_ZVAL(tmp); - convert_to_string(*tmp); - } else { - convert_to_string_ex(tmp); - } + SEPARATE_ZVAL(tmp); + convert_to_string(*tmp); } smart_str_appendl(&implstr, Z_STRVAL_PP(tmp), Z_STRLEN_PP(tmp)); -- 2.50.1