From 249f892455d2759d45a6f5976f03924c04910411 Mon Sep 17 00:00:00 2001 From: Xijian Yan Date: Mon, 6 Nov 2017 23:48:17 +0800 Subject: [PATCH] Fix crash when loading an empty mpeg file (#830) When loading an empty file (empty.txt -> empty.mp3 ), TagLib will crash. buffer.size() is 0, then buffer.size() - 1 is undefined (unsigned int) --- taglib/mpeg/mpegfile.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/taglib/mpeg/mpegfile.cpp b/taglib/mpeg/mpegfile.cpp index 217b03dd..517aea56 100644 --- a/taglib/mpeg/mpegfile.cpp +++ b/taglib/mpeg/mpegfile.cpp @@ -108,6 +108,9 @@ bool MPEG::File::isSupported(IOStream *stream) long headerOffset; const ByteVector buffer = Utils::readHeader(stream, bufferSize(), true, &headerOffset); + if(buffer.isEmpty()) + return false; + const long originalPosition = stream->tell(); AdapterFile file(stream); -- 2.40.0