From 242408dbef283ff148a3a671a7f4ebbad6118b22 Mon Sep 17 00:00:00 2001 From: Bruce Momjian Date: Tue, 3 Apr 2018 14:01:14 -0400 Subject: [PATCH] C comment: mention null handling in BuildTupleFromCStrings() Discussion: https://postgr.es/m/CAFjFpRcF-wNbe0w-m3NpkEwr9shmOZ=GoESOzd2Wog9h55J8sA@mail.gmail.com Author: Ashutosh Bapat --- src/backend/executor/execTuples.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/backend/executor/execTuples.c b/src/backend/executor/execTuples.c index ea06aeedb2..d14bf2ad69 100644 --- a/src/backend/executor/execTuples.c +++ b/src/backend/executor/execTuples.c @@ -1204,7 +1204,10 @@ BuildTupleFromCStrings(AttInMetadata *attinmeta, char **values) dvalues = (Datum *) palloc(natts * sizeof(Datum)); nulls = (bool *) palloc(natts * sizeof(bool)); - /* Call the "in" function for each non-dropped attribute */ + /* + * Call the "in" function for each non-dropped attribute, even for nulls, + * to support domains. + */ for (i = 0; i < natts; i++) { if (!TupleDescAttr(tupdesc, i)->attisdropped) -- 2.40.0