From 22f9705db579bc9c44db25e84af199d6a80a89e8 Mon Sep 17 00:00:00 2001 From: Magnus Jacobsson Date: Mon, 5 Jul 2021 12:24:02 +0200 Subject: [PATCH] don't disable leak detection for ctest based tests The current test does not trigger any memory leaks and we want to ensure that we don't introduce any new leaks and fix existing leaks as new tests encounter them. We still want leak detection disabled when running pytest since those tests still trigger many memory leaks. This is accomplished by moving the disabling of the leak detection into the test template and performing it after ctest has been executed, but before pytest executes. This commit also makes the temporary disabling of ODR violation bacause of lib/ortho to be selectively for ctest only. --- .gitlab-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 5e828dc70..013fd91e9 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -239,6 +239,9 @@ portable-source: - pushd build - ctest --output-on-failure - popd + # Many of the tests run by pytest currently trigger ASan + # memory leak detections. Disable those for now. + - export ASAN_OPTIONS=detect_leaks=0 - python3 -m pytest --verbose --junitxml=report.xml ci/tests.py tests rtest artifacts: reports: @@ -826,9 +829,6 @@ ubuntu21.04-cmake-ASan-test-including-ctest: - export CFLAGS=" -g -fsanitize=address,undefined" - export CXXFLAGS=" -g -fsanitize=address,undefined" - export LDFLAGS=" -g -fsanitize=address,undefined" - # FIXME: remove the following when Graphviz can pass the test suite - # leak-free - - export ASAN_OPTIONS=detect_leaks=0 - echo experimental > COLLECTION needs: - job: portable-source -- 2.50.1