From 22525de737679ace1488e63b7ed289bdb253ffc7 Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Tue, 19 Jun 2018 13:31:48 +0300 Subject: [PATCH] Use more specific asserts in dbm tests. (GH-7786) This may help to investigate bpo-33901. --- Lib/test/test_dbm.py | 2 +- Lib/test/test_dbm_gnu.py | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Lib/test/test_dbm.py b/Lib/test/test_dbm.py index 1884b5c683..1db3bef6f4 100644 --- a/Lib/test/test_dbm.py +++ b/Lib/test/test_dbm.py @@ -160,7 +160,7 @@ class WhichDBTestCase(unittest.TestCase): # and test that we can find it self.assertIn(b"1", f) # and read it - self.assertTrue(f[b"1"] == b"1") + self.assertEqual(f[b"1"], b"1") f.close() self.assertEqual(name, self.dbm.whichdb(_fname)) diff --git a/Lib/test/test_dbm_gnu.py b/Lib/test/test_dbm_gnu.py index 463d343411..50b8a192e5 100644 --- a/Lib/test/test_dbm_gnu.py +++ b/Lib/test/test_dbm_gnu.py @@ -74,7 +74,7 @@ class TestGdbm(unittest.TestCase): self.g['x'] = 'x' * 10000 size1 = os.path.getsize(filename) - self.assertTrue(size0 < size1) + self.assertGreater(size1, size0) del self.g['x'] # 'size' is supposed to be the same even after deleting an entry. @@ -82,7 +82,8 @@ class TestGdbm(unittest.TestCase): self.g.reorganize() size2 = os.path.getsize(filename) - self.assertTrue(size1 > size2 >= size0) + self.assertLess(size2, size1) + self.assertGreaterEqual(size2, size0) def test_context_manager(self): with gdbm.open(filename, 'c') as db: -- 2.40.0