From 21ccbbad7d964c4ee00b46a40f8733bef2ee126f Mon Sep 17 00:00:00 2001 From: Xinchen Hui Date: Thu, 3 Jul 2014 23:58:21 +0800 Subject: [PATCH] Fixed segfault if empty POST --- main/php_variables.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/main/php_variables.c b/main/php_variables.c index 30a84822af..fbd91dc286 100644 --- a/main/php_variables.c +++ b/main/php_variables.c @@ -328,9 +328,7 @@ SAPI_API SAPI_POST_HANDLER_FUNC(php_std_post_handler) smart_str_appendl(&post_data.str, buf, len); if (SUCCESS != add_post_vars(arr, &post_data, 0 TSRMLS_CC)) { - if (post_data.str.s) { - smart_str_free(&post_data.str); - } + smart_str_free(&post_data.str); return; } } @@ -340,8 +338,8 @@ SAPI_API SAPI_POST_HANDLER_FUNC(php_std_post_handler) } } - add_post_vars(arr, &post_data, 1 TSRMLS_CC); if (post_data.str.s) { + add_post_vars(arr, &post_data, 1 TSRMLS_CC); smart_str_free(&post_data.str); } } -- 2.40.0