From 20e2e0190aaa6df59a2a1c34e9bdcc6cdc90a3a2 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Andr=C3=A9=20Malo?= Date: Tue, 27 Jan 2004 00:43:41 +0000 Subject: [PATCH] issue a warning if an external rewrite map is used without RewriteLock. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102418 13f79535-47bb-0310-9956-ffa450edef68 --- modules/mappers/mod_rewrite.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/modules/mappers/mod_rewrite.c b/modules/mappers/mod_rewrite.c index e5e054082d..5a2122397d 100644 --- a/modules/mappers/mod_rewrite.c +++ b/modules/mappers/mod_rewrite.c @@ -1206,6 +1206,7 @@ static apr_status_t run_rewritemap_programs(server_rec *s, apr_pool_t *p) rewrite_server_conf *conf; apr_hash_index_t *hi; apr_status_t rc; + int lock_warning_issued = 0; conf = ap_get_module_config(s->module_config, &rewrite_module); @@ -1232,6 +1233,13 @@ static apr_status_t run_rewritemap_programs(server_rec *s, apr_pool_t *p) continue; } + if (!lock_warning_issued && (!lockname || !*lockname)) { + ap_log_error(APLOG_MARK, APLOG_WARNING, 0, s, + "mod_rewrite: Running external rewrite maps " + "without defining a RewriteLock is DANGEROUS!"); + ++lock_warning_issued; + } + rc = rewritemap_program_child(p, map->argv[0], map->argv, &fpout, &fpin); if (rc != APR_SUCCESS || fpin == NULL || fpout == NULL) { -- 2.50.1