From 208b00d03fcd16d71dc3942daa9e3a2c7b092322 Mon Sep 17 00:00:00 2001 From: Georg Brandl Date: Sat, 25 Apr 2009 15:11:29 +0000 Subject: [PATCH] #5841: add deprecation py3k warning and notice in the docs for commands module. --- Doc/library/commands.rst | 6 ++++++ Lib/commands.py | 8 ++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/Doc/library/commands.rst b/Doc/library/commands.rst index 84ef257a37..a700628c79 100644 --- a/Doc/library/commands.rst +++ b/Doc/library/commands.rst @@ -5,6 +5,12 @@ .. module:: commands :platform: Unix :synopsis: Utility functions for running external commands. + :deprecated: + +.. deprecated:: 2.6 + The :mod:`commands` module has been removed in Python 3.0. Use the + :mod:`subprocess` module instead. + .. sectionauthor:: Sue Williams diff --git a/Lib/commands.py b/Lib/commands.py index 287aa27f4d..ccaaaee6ff 100644 --- a/Lib/commands.py +++ b/Lib/commands.py @@ -18,6 +18,10 @@ Encapsulates the basic operation: [Note: it would be nice to add functions to interpret the exit status.] """ +from warnings import warnpy3k +warnpy3k("the commands module has been removed in Python 3.0; " + "use the subprocess module instead", stacklevel=2) +del warnpy3k __all__ = ["getstatusoutput","getoutput","getstatus"] @@ -63,8 +67,6 @@ def getstatusoutput(cmd): # Make command argument from directory and pathname (prefix space, add quotes). # def mk2arg(head, x): - from warnings import warnpy3k - warnpy3k("In 3.x, mk2arg has been removed.") import os return mkarg(os.path.join(head, x)) @@ -77,8 +79,6 @@ def mk2arg(head, x): # with backslash. # def mkarg(x): - from warnings import warnpy3k - warnpy3k("in 3.x, mkarg has been removed.") if '\'' not in x: return ' \'' + x + '\'' s = ' "' -- 2.50.0