From 2081db79827e0fbc3088dcd693f8af7d7d0191a4 Mon Sep 17 00:00:00 2001 From: Serapheim Dimitropoulos Date: Mon, 12 Aug 2019 09:49:07 -0700 Subject: [PATCH] Sort log spacemap tunables in alphabetical order Beside the whole commit being a nit in reality it should bring the diffs of the spa_log_spacemap.c source file between ZoL and delphix/zfs to 0. Reviewed-by: George Melikov Reviewed-by: Chris Dunlop Reviewed-by: Brian Behlendorf Signed-off-by: Serapheim Dimitropoulos Closes #9143 --- module/zfs/spa_log_spacemap.c | 64 +++++++++++++++++------------------ 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/module/zfs/spa_log_spacemap.c b/module/zfs/spa_log_spacemap.c index bb6610fe0..ad82e025e 100644 --- a/module/zfs/spa_log_spacemap.c +++ b/module/zfs/spa_log_spacemap.c @@ -1283,26 +1283,24 @@ spa_ld_log_spacemaps(spa_t *spa) #if defined(_KERNEL) /* BEGIN CSTYLED */ -module_param(zfs_unflushed_max_mem_amt, ulong, 0644); -MODULE_PARM_DESC(zfs_unflushed_max_mem_amt, - "Specific hard-limit in memory that ZFS allows to be used for " - "unflushed changes"); +module_param(zfs_keep_log_spacemaps_at_export, int, 0644); +MODULE_PARM_DESC(zfs_keep_log_spacemaps_at_export, + "Prevent the log spacemaps from being flushed and destroyed " + "during pool export/destroy"); -module_param(zfs_unflushed_max_mem_ppm, ulong, 0644); -MODULE_PARM_DESC(zfs_unflushed_max_mem_ppm, - "Percentage of the overall system memory that ZFS allows to be " - "used for unflushed changes (value is calculated over 1000000 for " - "finer granularity"); +module_param(zfs_max_logsm_summary_length, ulong, 0644); +MODULE_PARM_DESC(zfs_max_logsm_summary_length, + "Maximum number of rows allowed in the summary of " + "the spacemap log"); -module_param(zfs_unflushed_log_block_max, ulong, 0644); -MODULE_PARM_DESC(zfs_unflushed_log_block_max, - "Hard limit (upper-bound) in the size of the space map log " - "in terms of blocks."); +module_param(zfs_max_log_walking, ulong, 0644); +MODULE_PARM_DESC(zfs_max_log_walking, + "The number of past TXGs that the flushing algorithm of the log " + "spacemap feature uses to estimate incoming log blocks"); -module_param(zfs_unflushed_log_block_min, ulong, 0644); -MODULE_PARM_DESC(zfs_unflushed_log_block_min, - "Lower-bound limit for the maximum amount of blocks allowed in " - "log spacemap (see zfs_unflushed_log_block_max)"); +module_param(zfs_min_metaslabs_to_flush, ulong, 0644); +MODULE_PARM_DESC(zfs_min_metaslabs_to_flush, + "Minimum number of metaslabs to flush per dirty TXG"); module_param(zfs_unflushed_log_block_pct, ulong, 0644); MODULE_PARM_DESC(zfs_unflushed_log_block_pct, @@ -1312,23 +1310,25 @@ MODULE_PARM_DESC(zfs_unflushed_log_block_pct, " number of log blocks is capped at 4 times the number of " "metaslabs)"); -module_param(zfs_max_log_walking, ulong, 0644); -MODULE_PARM_DESC(zfs_max_log_walking, - "The number of past TXGs that the flushing algorithm of the log " - "spacemap feature uses to estimate incoming log blocks"); +module_param(zfs_unflushed_log_block_max, ulong, 0644); +MODULE_PARM_DESC(zfs_unflushed_log_block_max, + "Hard limit (upper-bound) in the size of the space map log " + "in terms of blocks."); -module_param(zfs_max_logsm_summary_length, ulong, 0644); -MODULE_PARM_DESC(zfs_max_logsm_summary_length, - "Maximum number of rows allowed in the summary of " - "the spacemap log"); +module_param(zfs_unflushed_log_block_min, ulong, 0644); +MODULE_PARM_DESC(zfs_unflushed_log_block_min, + "Lower-bound limit for the maximum amount of blocks in " + "log spacemap."); -module_param(zfs_min_metaslabs_to_flush, ulong, 0644); -MODULE_PARM_DESC(zfs_min_metaslabs_to_flush, - "Minimum number of metaslabs to flush per dirty TXG"); +module_param(zfs_unflushed_max_mem_amt, ulong, 0644); +MODULE_PARM_DESC(zfs_unflushed_max_mem_amt, + "Specific hard-limit in memory that ZFS allows to be used for " + "unflushed changes"); -module_param(zfs_keep_log_spacemaps_at_export, int, 0644); -MODULE_PARM_DESC(zfs_keep_log_spacemaps_at_export, - "Prevent the log spacemaps from being flushed and destroyed " - "during pool export/destroy"); +module_param(zfs_unflushed_max_mem_ppm, ulong, 0644); +MODULE_PARM_DESC(zfs_unflushed_max_mem_ppm, + "Percentage of the overall system memory that ZFS allows to be " + "used for unflushed changes (value is calculated over 1000000 for " + "finer granularity"); /* END CSTYLED */ #endif -- 2.40.0