From 1fd9e0def66fbd50e99be5ff87c9fd1c91c428ab Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Tue, 7 Dec 2010 00:05:48 +0000 Subject: [PATCH] Use atomic operations for libclang's object count tracking. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@121073 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Frontend/ASTUnit.cpp | 7 ++++--- tools/libclang/CIndexCodeCompletion.cpp | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/Frontend/ASTUnit.cpp b/lib/Frontend/ASTUnit.cpp index 586002daef..97e03266eb 100644 --- a/lib/Frontend/ASTUnit.cpp +++ b/lib/Frontend/ASTUnit.cpp @@ -35,6 +35,7 @@ #include "clang/Basic/TargetInfo.h" #include "clang/Basic/Diagnostic.h" #include "llvm/ADT/StringSet.h" +#include "llvm/Support/Atomic.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/Host.h" #include "llvm/Support/Path.h" @@ -85,7 +86,7 @@ const unsigned DefaultPreambleRebuildInterval = 5; /// \brief Tracks the number of ASTUnit objects that are currently active. /// /// Used for debugging purposes only. -static unsigned ActiveASTUnitObjects; +static llvm::sys::cas_flag ActiveASTUnitObjects; ASTUnit::ASTUnit(bool _MainFileIsAST) : CaptureDiagnostics(false), MainFileIsAST(_MainFileIsAST), @@ -98,7 +99,7 @@ ASTUnit::ASTUnit(bool _MainFileIsAST) CacheCodeCompletionCoolDown(0), UnsafeToFree(false) { if (getenv("LIBCLANG_OBJTRACKING")) { - ++ActiveASTUnitObjects; + llvm::sys::AtomicIncrement(&ActiveASTUnitObjects); fprintf(stderr, "+++ %d translation units\n", ActiveASTUnitObjects); } } @@ -129,7 +130,7 @@ ASTUnit::~ASTUnit() { ClearCachedCompletionResults(); if (getenv("LIBCLANG_OBJTRACKING")) { - --ActiveASTUnitObjects; + llvm::sys::AtomicDecrement(&ActiveASTUnitObjects); fprintf(stderr, "--- %d translation units\n", ActiveASTUnitObjects); } } diff --git a/tools/libclang/CIndexCodeCompletion.cpp b/tools/libclang/CIndexCodeCompletion.cpp index 7441f4fa1d..02e45052ab 100644 --- a/tools/libclang/CIndexCodeCompletion.cpp +++ b/tools/libclang/CIndexCodeCompletion.cpp @@ -24,6 +24,7 @@ #include "clang/Sema/CodeCompleteConsumer.h" #include "llvm/ADT/SmallString.h" #include "llvm/ADT/StringExtras.h" +#include "llvm/Support/Atomic.h" #include "llvm/Support/CrashRecoveryContext.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/Timer.h" @@ -256,7 +257,7 @@ struct AllocatedCXCodeCompleteResults : public CXCodeCompleteResults { /// currently active. /// /// Used for debugging purposes only. -static unsigned CodeCompletionResultObjects; +static llvm::sys::cas_flag CodeCompletionResultObjects; AllocatedCXCodeCompleteResults::AllocatedCXCodeCompleteResults() : CXCodeCompleteResults(), @@ -265,7 +266,7 @@ AllocatedCXCodeCompleteResults::AllocatedCXCodeCompleteResults() FileMgr(FileSystemOpts), SourceMgr(*Diag, FileMgr) { if (getenv("LIBCLANG_OBJTRACKING")) { - ++CodeCompletionResultObjects; + llvm::sys::AtomicIncrement(&CodeCompletionResultObjects); fprintf(stderr, "+++ %d completion results\n", CodeCompletionResultObjects); } } @@ -281,7 +282,7 @@ AllocatedCXCodeCompleteResults::~AllocatedCXCodeCompleteResults() { delete TemporaryBuffers[I]; if (getenv("LIBCLANG_OBJTRACKING")) { - --CodeCompletionResultObjects; + llvm::sys::AtomicDecrement(&CodeCompletionResultObjects); fprintf(stderr, "--- %d completion results\n", CodeCompletionResultObjects); } } -- 2.40.0