From 1facee1b94a6a69a58e31bd5807398b78823de9b Mon Sep 17 00:00:00 2001 From: Dmitry Stogov Date: Fri, 3 Mar 2006 09:20:51 +0000 Subject: [PATCH] Fixed bug #36575 (SOAP: Incorrect complex type instantiation with hierarchies) --- ext/soap/php_encoding.c | 50 ++++++++++++++++-- ext/soap/soap.c | 1 + ext/soap/tests/bugs/bug35142.phpt | 20 +++---- ext/soap/tests/bugs/bug36226.phpt | 26 ++++----- ext/soap/tests/bugs/bug36575.phpt | 52 ++++++++++++++++++ ext/soap/tests/bugs/bug36575.wsdl | 87 +++++++++++++++++++++++++++++++ ext/soap/tests/classmap003.phpt | 2 +- 7 files changed, 210 insertions(+), 28 deletions(-) create mode 100755 ext/soap/tests/bugs/bug36575.phpt create mode 100755 ext/soap/tests/bugs/bug36575.wsdl diff --git a/ext/soap/php_encoding.c b/ext/soap/php_encoding.c index 011f63fca2..729e3631f9 100644 --- a/ext/soap/php_encoding.c +++ b/ext/soap/php_encoding.c @@ -246,6 +246,23 @@ void whiteSpace_collapse(char* str) *pos = '\0'; } +static encodePtr find_encoder_by_type_name(sdlPtr sdl, const char *type) +{ + if (sdl && sdl->encoders) { + HashPosition pos; + encodePtr *enc; + + for (zend_hash_internal_pointer_reset_ex(sdl->encoders, &pos); + zend_hash_get_current_data_ex(sdl->encoders, (void **) &enc, &pos) == SUCCESS; + zend_hash_move_forward_ex(sdl->encoders, &pos)) { + if (strcmp((*enc)->details.type_str, type) == 0) { + return *enc; + } + } + } + return NULL; +} + xmlNodePtr master_to_xml(encodePtr encode, zval *data, int style, xmlNodePtr parent) { xmlNodePtr node = NULL; @@ -329,7 +346,12 @@ xmlNodePtr master_to_xml(encodePtr encode, zval *data, int style, xmlNodePtr par encodePtr enc = get_encoder(SOAP_GLOBAL(sdl), SOAP_GLOBAL(sdl)->target_ns, type_name); if (enc) { encode = enc; - } + } else if (SOAP_GLOBAL(sdl)) { + enc = find_encoder_by_type_name(SOAP_GLOBAL(sdl), type_name); + if (enc) { + encode = enc; + } + } break; } } @@ -1202,7 +1224,7 @@ static void model_to_zval_object(zval *ret, sdlContentModelPtr model, xmlNodePtr } /* Struct encode/decode */ -static zval *to_zval_object(encodeTypePtr type, xmlNodePtr data) +static zval *to_zval_object_ex(encodeTypePtr type, xmlNodePtr data, zend_class_entry *pce) { zval *ret; xmlNodePtr trav; @@ -1213,7 +1235,9 @@ static zval *to_zval_object(encodeTypePtr type, xmlNodePtr data) TSRMLS_FETCH(); ce = ZEND_STANDARD_CLASS_DEF_PTR; - if (SOAP_GLOBAL(class_map) && type->type_str) { + if (pce) { + ce = pce; + } else if (SOAP_GLOBAL(class_map) && type->type_str) { zval **classname; zend_class_entry *tmp; @@ -1256,7 +1280,20 @@ static zval *to_zval_object(encodeTypePtr type, xmlNodePtr data) sdlType->encode->details.sdl_type->kind != XSD_TYPEKIND_SIMPLE && sdlType->encode->details.sdl_type->kind != XSD_TYPEKIND_LIST && sdlType->encode->details.sdl_type->kind != XSD_TYPEKIND_UNION) { - ret = master_to_zval_int(sdlType->encode, data); + + if (ce != ZEND_STANDARD_CLASS_DEF_PTR && + sdlType->encode->to_zval == sdl_guess_convert_zval && + sdlType->encode->details.sdl_type != NULL && + (sdlType->encode->details.sdl_type->kind == XSD_TYPEKIND_COMPLEX || + sdlType->encode->details.sdl_type->kind == XSD_TYPEKIND_RESTRICTION || + sdlType->encode->details.sdl_type->kind == XSD_TYPEKIND_EXTENSION) && + (sdlType->encode->details.sdl_type->encode == NULL || + (sdlType->encode->details.sdl_type->encode->details.type != IS_ARRAY && + sdlType->encode->details.sdl_type->encode->details.type != SOAP_ENC_ARRAY))) { + ret = to_zval_object_ex(&sdlType->encode->details, data, ce); + } else { + ret = master_to_zval_int(sdlType->encode, data); + } FIND_XML_NULL(data, ret); if (get_zval_property(ret, "any" TSRMLS_CC) != NULL) { unset_zval_property(ret, "any" TSRMLS_CC); @@ -1361,6 +1398,11 @@ static zval *to_zval_object(encodeTypePtr type, xmlNodePtr data) return ret; } +static zval *to_zval_object(encodeTypePtr type, xmlNodePtr data) +{ + return to_zval_object_ex(type, data, NULL); +} + static int model_to_xml_object(xmlNodePtr node, sdlContentModelPtr model, zval *object, int style, int strict TSRMLS_DC) { switch (model->kind) { diff --git a/ext/soap/soap.c b/ext/soap/soap.c index 9d76adb9d8..1eea723a95 100644 --- a/ext/soap/soap.c +++ b/ext/soap/soap.c @@ -2197,6 +2197,7 @@ PHP_METHOD(SoapClient, SoapClient) MAKE_STD_ZVAL(class_map); *class_map = **tmp; + INIT_PZVAL(class_map); zval_copy_ctor(class_map); #ifdef ZEND_ENGINE_2 class_map->refcount--; diff --git a/ext/soap/tests/bugs/bug35142.phpt b/ext/soap/tests/bugs/bug35142.phpt index b27d9bc6d9..e12b5ad98a 100755 --- a/ext/soap/tests/bugs/bug35142.phpt +++ b/ext/soap/tests/bugs/bug35142.phpt @@ -49,7 +49,7 @@ class LogOffEvent { public $audienceMemberId; public $timestamp; public $smokeStatus; - public $callInititator; + public $callInitiator; function __construct($audienceMemberId, $timestamp, $smokeStatus) { $this->audienceMemberId = $audienceMemberId; @@ -98,6 +98,15 @@ object(IVREvents)#%d (6) { int(101) ["messageId"]=> int(12345) + ["source"]=> + string(3) "IVR" + ["logOnEvent"]=> + object(LogOnEvent)#%d (2) { + ["audienceMemberId"]=> + int(34567) + ["timestamp"]=> + string(25) "2005-11-08T11:22:07+03:00" + } ["logOffEvent"]=> array(2) { [0]=> @@ -123,13 +132,4 @@ object(IVREvents)#%d (6) { string(3) "IVR" } } - ["logOnEvent"]=> - object(LogOnEvent)#%d (2) { - ["audienceMemberId"]=> - int(34567) - ["timestamp"]=> - string(25) "2005-11-08T11:22:07+03:00" - } - ["source"]=> - string(3) "IVR" } diff --git a/ext/soap/tests/bugs/bug36226.phpt b/ext/soap/tests/bugs/bug36226.phpt index 572a380b02..c88d969f29 100755 --- a/ext/soap/tests/bugs/bug36226.phpt +++ b/ext/soap/tests/bugs/bug36226.phpt @@ -50,7 +50,7 @@ class LogOffEvent { public $audienceMemberId; public $timestamp; public $smokeStatus; - public $callInititator; + public $callInitiator; function __construct($audienceMemberId, $timestamp, $smokeStatus) { $this->audienceMemberId = $audienceMemberId; @@ -99,6 +99,18 @@ object(IVREvents)#%d (6) { int(101) ["messageId"]=> int(12345) + ["source"]=> + string(3) "IVR" + ["logOnEvent"]=> + array(1) { + [0]=> + object(LogOnEvent)#10 (2) { + ["audienceMemberId"]=> + int(34567) + ["timestamp"]=> + string(25) "2005-11-08T11:22:07+03:00" + } + } ["logOffEvent"]=> array(2) { [0]=> @@ -124,16 +136,4 @@ object(IVREvents)#%d (6) { string(3) "IVR" } } - ["logOnEvent"]=> - array(1) { - [0]=> - object(LogOnEvent)#10 (2) { - ["audienceMemberId"]=> - int(34567) - ["timestamp"]=> - string(25) "2005-11-08T11:22:07+03:00" - } - } - ["source"]=> - string(3) "IVR" } diff --git a/ext/soap/tests/bugs/bug36575.phpt b/ext/soap/tests/bugs/bug36575.phpt new file mode 100755 index 0000000000..aad8fcad6a --- /dev/null +++ b/ext/soap/tests/bugs/bug36575.phpt @@ -0,0 +1,52 @@ +--TEST-- +Bug #36575 (Incorrect complex type instantiation with hierarchies) +--SKIPIF-- + +--INI-- +soap.wsdl_cache_enabled=0 +--FILE-- +var1 = $a1->var1; + $a3->var2 = "var two"; + $a3->var3 = "var three"; + return $a3; +} + +$classMap = array("A1" => "CT_A1", "A2" => "CT_A2", "A3" => "CT_A3"); + +$client = new SoapClient(dirname(__FILE__)."/bug36575.wsdl", array("trace" => 1, "exceptions" => 0, "classmap" => $classMap)); +$a2 = new CT_A2(); +$a2->var1 = "one"; +$a2->var2 = "two"; +$client->test($a2); + +$soapRequest = $client->__getLastRequest(); + +echo $soapRequest; + +$server = new SoapServer(dirname(__FILE__)."/bug36575.wsdl", array("classmap" => $classMap)); +$server->addFunction("test"); +$server->handle($soapRequest); +echo "ok\n"; +?> +--EXPECT-- + +onetwo + +onevar twovar three +ok diff --git a/ext/soap/tests/bugs/bug36575.wsdl b/ext/soap/tests/bugs/bug36575.wsdl new file mode 100755 index 0000000000..0f1899bcd5 --- /dev/null +++ b/ext/soap/tests/bugs/bug36575.wsdl @@ -0,0 +1,87 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/ext/soap/tests/classmap003.phpt b/ext/soap/tests/classmap003.phpt index c126709054..ac87a1682e 100755 --- a/ext/soap/tests/classmap003.phpt +++ b/ext/soap/tests/classmap003.phpt @@ -49,6 +49,6 @@ print_r($client->f()); --EXPECT-- B Object ( - [x] => 5 [y] => 6 + [x] => 5 ) -- 2.40.0