From 1fa398ce2e03d565bcd327da133a2f25b1fd8488 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Mon, 28 Sep 2015 23:48:52 +0000 Subject: [PATCH] Add an explicitly defaulted copy ctor (and FIXME) to Command since its copy ctor is currently used (and actually slices derived objects... ) in some diagnostics handling. Justin mentioned he'd look into this. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@248760 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/Driver/Job.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/clang/Driver/Job.h b/include/clang/Driver/Job.h index 526aff42e5..263356f396 100644 --- a/include/clang/Driver/Job.h +++ b/include/clang/Driver/Job.h @@ -85,6 +85,9 @@ public: Command(const Action &Source, const Tool &Creator, const char *Executable, const llvm::opt::ArgStringList &Arguments, ArrayRef Inputs); + // FIXME: This really shouldn't be copyable, but is currently copied in some + // error handling in Driver::generateCompilationDiagnostics. + Command(const Command &) = default; virtual ~Command() {} virtual void Print(llvm::raw_ostream &OS, const char *Terminator, bool Quote, -- 2.40.0