From 1ec43d2bfc9393ebcfb41bcf3ebf0b50393f844e Mon Sep 17 00:00:00 2001 From: Owen Reynolds Date: Fri, 4 Oct 2019 12:26:25 +0000 Subject: [PATCH] [llvm-ar][test] Clarified comment The test is dependant on the installation of the en_US.UTF-8 locale. The reasoning for this is clarified in the amended comment. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@373737 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/tools/llvm-ar/mri-utf8.test | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/tools/llvm-ar/mri-utf8.test b/test/tools/llvm-ar/mri-utf8.test index 64999960074..e297dce8d8a 100644 --- a/test/tools/llvm-ar/mri-utf8.test +++ b/test/tools/llvm-ar/mri-utf8.test @@ -16,4 +16,8 @@ RUN: cd %t/extracted && llvm-ar x %t/mri.ar # include arguments with non-ascii characters. # Python on Linux defaults to ASCII encoding unless the # environment specifies otherwise, so it is explicitly set. +# The reliance the test has on this locale is not ideal, +# however alternate solutions have been difficult due to +# behaviour differences with python 2 vs python 3, +# and linux vs windows. RUN: env LANG=en_US.UTF-8 %python -c "assert open(u'\U000000A3.txt', 'rb').read() == b'contents\n'" -- 2.40.0