From 1e600dc01fa294deb05243378e7419df1b6750ba Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C3=89ric=20Araujo?= Date: Mon, 22 Nov 2010 03:13:47 +0000 Subject: [PATCH] Fix resource warning from patchcheck.py --- Tools/scripts/patchcheck.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/Tools/scripts/patchcheck.py b/Tools/scripts/patchcheck.py index caffc9d4c4..e767edabd9 100644 --- a/Tools/scripts/patchcheck.py +++ b/Tools/scripts/patchcheck.py @@ -45,13 +45,16 @@ def changed_files(): sys.exit('need a checkout to get modified files') st = subprocess.Popen(cmd.split(), stdout=subprocess.PIPE) - st.wait() - if vcs == 'hg': - return [x.decode().rstrip() for x in st.stdout] - else: - output = (x.decode().rstrip().rsplit(None, 1)[-1] - for x in st.stdout if x[0] in b'AM') + try: + st.wait() + if vcs == 'hg': + return [x.decode().rstrip() for x in st.stdout] + else: + output = (x.decode().rstrip().rsplit(None, 1)[-1] + for x in st.stdout if x[0] in b'AM') return set(path for path in output if os.path.isfile(path)) + finally: + st.stdout.close() def report_modified_files(file_paths): -- 2.40.0