From 1df323a196a8cb6db34e06c999797544ebafec22 Mon Sep 17 00:00:00 2001 From: "Kurt B. Kaiser" Date: Thu, 14 Feb 2008 04:02:10 +0000 Subject: [PATCH] 1. Avoid hang when encountering a duplicate in a completion list. Bug 1571112. 2. Duplicate some old entries from Python's NEWS to IDLE's NEWS.txt Backport of r53042 --- Lib/idlelib/AutoCompleteWindow.py | 5 ++++- Lib/idlelib/NEWS.txt | 14 +++++++++++++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/Lib/idlelib/AutoCompleteWindow.py b/Lib/idlelib/AutoCompleteWindow.py index d8bbff4a17..d02a69539a 100644 --- a/Lib/idlelib/AutoCompleteWindow.py +++ b/Lib/idlelib/AutoCompleteWindow.py @@ -118,8 +118,11 @@ class AutoCompleteWindow: i = 0 while i < len(lts) and i < len(selstart) and lts[i] == selstart[i]: i += 1 - while cursel > 0 and selstart[:i] <= self.completions[cursel-1]: + previous_completion = self.completions[cursel - 1] + while cursel > 0 and selstart[:i] <= previous_completion: i += 1 + if selstart == previous_completion: + break # maybe we have a duplicate? newstart = selstart[:i] self._change_start(newstart) diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt index 178aee4710..5e94c377b4 100644 --- a/Lib/idlelib/NEWS.txt +++ b/Lib/idlelib/NEWS.txt @@ -3,11 +3,14 @@ What's New in IDLE 1.2.2c1? *Release date: XX-FEB-2008* +- Avoid hang when encountering a duplicate in a completion list. Bug 1571112. + (backport r53042) + - Some syntax errors were being caught by tokenize during the tabnanny check, resulting in obscure error messages. Do the syntax check first. Bug 1562716, 1562719 (backport r52083) -- Patch 1693258: Fix for duplicate "preferences" menu-OS X. Backport of r56204. +- Patch 1693258: Fix for duplicate "preferences" menu-OS X. (backport r56204) - OSX: Avoid crash for those versions of Tcl/Tk which don't have a console @@ -70,6 +73,13 @@ What's New in IDLE 1.2b3? *Release date: 03-AUG-2006* +- Bug #1525817: Don't truncate short lines in IDLE's tool tips. + +- Bug #1517990: IDLE keybindings on MacOS X now work correctly + +- Bug #1517996: IDLE no longer shows the default Tk menu when a + path browser, class browser or debugger is the frontmost window on MacOS X + - EditorWindow.test() was failing. Bug 1417598 - EditorWindow failed when used stand-alone if sys.ps1 not set. @@ -106,6 +116,8 @@ What's New in IDLE 1.2a1? *Release date: 05-APR-2006* +- Patch #1162825: Support non-ASCII characters in IDLE window titles. + - Source file f.flush() after writing; trying to avoid lossage if user kills GUI. -- 2.50.0