From 1d56ed5210babb68b5798cd943bb21f417e781ee Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Thu, 29 Jun 2017 10:53:34 +0200 Subject: [PATCH] _winconsoleio: Fix memory leak (#2485) Fix memory leak when _winconsoleio tries to open a non-console file: free the name buffer. --- Modules/_io/winconsoleio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Modules/_io/winconsoleio.c b/Modules/_io/winconsoleio.c index 346c38637f..5cf3f070d8 100644 --- a/Modules/_io/winconsoleio.c +++ b/Modules/_io/winconsoleio.c @@ -317,6 +317,7 @@ _io__WindowsConsoleIO___init___impl(winconsoleio *self, PyObject *nameobj, if (name == NULL) return -1; if (console_type == '\0') { + PyMem_Free(name); PyErr_SetString(PyExc_ValueError, "Cannot open non-console file"); return -1; @@ -400,7 +401,7 @@ _io__WindowsConsoleIO___init___impl(winconsoleio *self, PyObject *nameobj, PyErr_SetString(PyExc_ValueError, "Cannot open non-console file"); goto error; - } + } if (self->writable && console_type != 'w') { PyErr_SetString(PyExc_ValueError, "Cannot open console input buffer for writing"); @@ -428,8 +429,7 @@ error: internal_close(self); done: - if (name) - PyMem_Free(name); + PyMem_Free(name); return ret; } -- 2.40.0