From 1c1de0c41a74b4deadd11cb18f00f115db0568ec Mon Sep 17 00:00:00 2001 From: George Peter Banyard Date: Sat, 13 Jul 2019 02:05:17 +0200 Subject: [PATCH] Convert all php_error_docref0 to php_error_docref Closes GH-4394 --- ext/dba/dba_lmdb.c | 12 ++++++------ ext/intl/idn/idn.c | 2 +- ext/intl/timezone/timezone_class.cpp | 2 +- ext/intl/transliterator/transliterator_class.c | 4 ++-- ext/intl/transliterator/transliterator_methods.c | 2 +- ext/sockets/conversions.c | 2 +- ext/sockets/sendrecvmsg.c | 10 +++++----- ext/standard/html.c | 2 +- main/main.c | 6 +++--- main/php.h | 4 +--- 10 files changed, 22 insertions(+), 24 deletions(-) diff --git a/ext/dba/dba_lmdb.c b/ext/dba/dba_lmdb.c index 058c4c3d28..4bc085177d 100644 --- a/ext/dba/dba_lmdb.c +++ b/ext/dba/dba_lmdb.c @@ -251,14 +251,14 @@ DBA_FIRSTKEY_FUNC(lmdb) rc = mdb_txn_begin(LMDB_IT(env), NULL, MDB_RDONLY, &LMDB_IT(txn)); if (rc) { - php_error_docref0(NULL, E_WARNING, "%s", mdb_strerror(rc)); + php_error_docref(NULL, E_WARNING, "%s", mdb_strerror(rc)); return NULL; } rc = mdb_cursor_open(LMDB_IT(txn), LMDB_IT(dbi), &LMDB_IT(cur)); if (rc) { mdb_txn_abort(LMDB_IT(txn)); - php_error_docref0(NULL, E_WARNING, "%s", mdb_strerror(rc)); + php_error_docref(NULL, E_WARNING, "%s", mdb_strerror(rc)); return NULL; } @@ -268,7 +268,7 @@ DBA_FIRSTKEY_FUNC(lmdb) mdb_cursor_close(LMDB_IT(cur)); LMDB_IT(cur) = NULL; if (MDB_NOTFOUND != rc) { - php_error_docref0(NULL, E_WARNING, "%s", mdb_strerror(rc)); + php_error_docref(NULL, E_WARNING, "%s", mdb_strerror(rc)); } return NULL; } @@ -291,7 +291,7 @@ DBA_NEXTKEY_FUNC(lmdb) rc = mdb_txn_renew(LMDB_IT(txn)); if (rc) { - php_error_docref0(NULL, E_WARNING, "%s", mdb_strerror(rc)); + php_error_docref(NULL, E_WARNING, "%s", mdb_strerror(rc)); return NULL; } @@ -301,7 +301,7 @@ DBA_NEXTKEY_FUNC(lmdb) mdb_cursor_close(LMDB_IT(cur)); LMDB_IT(cur) = NULL; if (MDB_NOTFOUND != rc) { - php_error_docref0(NULL, E_WARNING, "%s", mdb_strerror(rc)); + php_error_docref(NULL, E_WARNING, "%s", mdb_strerror(rc)); } return NULL; } @@ -327,7 +327,7 @@ DBA_SYNC_FUNC(lmdb) rc = mdb_env_sync(LMDB_IT(env), 1); if (rc) { - php_error_docref0(NULL, E_WARNING, "%s", mdb_strerror(rc)); + php_error_docref(NULL, E_WARNING, "%s", mdb_strerror(rc)); return FAILURE; } diff --git a/ext/intl/idn/idn.c b/ext/intl/idn/idn.c index 1bd0d069bf..55fbe56c9a 100644 --- a/ext/intl/idn/idn.c +++ b/ext/intl/idn/idn.c @@ -287,7 +287,7 @@ static void php_intl_idn_handoff(INTERNAL_FUNCTION_PARAMETERS, int mode) if (idna_info != NULL) { if (variant == INTL_IDN_VARIANT_2003) { - php_error_docref0(NULL, E_NOTICE, + php_error_docref(NULL, E_NOTICE, "4 arguments were provided, but INTL_IDNA_VARIANT_2003 only " "takes 3 - extra argument ignored"); } else { diff --git a/ext/intl/timezone/timezone_class.cpp b/ext/intl/timezone/timezone_class.cpp index 695cc7d3ea..b261f81f81 100644 --- a/ext/intl/timezone/timezone_class.cpp +++ b/ext/intl/timezone/timezone_class.cpp @@ -505,7 +505,7 @@ U_CFUNC void timezone_register_IntlTimeZone_class(void) TimeZone_ce_ptr = zend_register_internal_class(&ce); if (!TimeZone_ce_ptr) { //can't happen now without bigger problems before - php_error_docref0(NULL, E_ERROR, + php_error_docref(NULL, E_ERROR, "IntlTimeZone: class registration has failed."); return; } diff --git a/ext/intl/transliterator/transliterator_class.c b/ext/intl/transliterator/transliterator_class.c index d5aac5df16..4417fba4f0 100644 --- a/ext/intl/transliterator/transliterator_class.c +++ b/ext/intl/transliterator/transliterator_class.c @@ -241,7 +241,7 @@ static zval *Transliterator_read_property( zval *object, zval *member, int type, ( zend_binary_strcmp( "id", sizeof( "id" ) - 1, Z_STRVAL_P( member ), Z_STRLEN_P( member ) ) == 0 ) ) { - php_error_docref0( NULL, E_WARNING, "The property \"id\" is read-only" ); + php_error_docref(NULL, E_WARNING, "The property \"id\" is read-only" ); retval = &EG( uninitialized_zval ); } else @@ -271,7 +271,7 @@ static zval *Transliterator_write_property( zval *object, zval *member, zval *va ( zend_binary_strcmp( "id", sizeof( "id" ) - 1, Z_STRVAL_P( member ), Z_STRLEN_P( member ) ) == 0 ) ) { - php_error_docref0( NULL, E_WARNING, "The property \"id\" is read-only" ); + php_error_docref(NULL, E_WARNING, "The property \"id\" is read-only" ); } else { diff --git a/ext/intl/transliterator/transliterator_methods.c b/ext/intl/transliterator/transliterator_methods.c index 50dd344671..f1518d80a1 100644 --- a/ext/intl/transliterator/transliterator_methods.c +++ b/ext/intl/transliterator/transliterator_methods.c @@ -339,7 +339,7 @@ PHP_FUNCTION( transliterator_transliterate ) if( res == FAILURE ) { zend_string *message = intl_error_get_message( NULL ); - php_error_docref0( NULL, E_WARNING, "Could not create " + php_error_docref(NULL, E_WARNING, "Could not create " "transliterator with ID \"%s\" (%s)", Z_STRVAL_P( arg1 ), ZSTR_VAL(message) ); zend_string_free( message ); ZVAL_UNDEF(&tmp_object); diff --git a/ext/sockets/conversions.c b/ext/sockets/conversions.c index cbddc9d096..b7dae45407 100644 --- a/ext/sockets/conversions.c +++ b/ext/sockets/conversions.c @@ -199,7 +199,7 @@ static void do_to_zval_err(res_context *ctx, const char *fmt, ...) void err_msg_dispose(struct err_s *err) { if (err->msg != NULL) { - php_error_docref0(NULL, err->level, "%s", err->msg); + php_error_docref(NULL, err->level, "%s", err->msg); if (err->should_free) { efree(err->msg); } diff --git a/ext/sockets/sendrecvmsg.c b/ext/sockets/sendrecvmsg.c index 27bee1edce..ce3cb79605 100644 --- a/ext/sockets/sendrecvmsg.c +++ b/ext/sockets/sendrecvmsg.c @@ -71,7 +71,7 @@ inline ssize_t sendmsg(int sockfd, const struct msghdr *msg, int flags) #define LONG_CHECK_VALID_INT(l) \ do { \ if ((l) < INT_MIN && (l) > INT_MAX) { \ - php_error_docref0(NULL, E_WARNING, "The value " ZEND_LONG_FMT " does not fit inside " \ + php_error_docref(NULL, E_WARNING, "The value " ZEND_LONG_FMT " does not fit inside " \ "the boundaries of a native integer", (l)); \ return; \ } \ @@ -292,14 +292,14 @@ PHP_FUNCTION(socket_cmsg_space) LONG_CHECK_VALID_INT(n); if (n < 0) { - php_error_docref0(NULL, E_WARNING, "The third argument " + php_error_docref(NULL, E_WARNING, "The third argument " "cannot be negative"); return; } entry = get_ancillary_reg_entry(level, type); if (entry == NULL) { - php_error_docref0(NULL, E_WARNING, "The pair level " ZEND_LONG_FMT "/type " ZEND_LONG_FMT " is " + php_error_docref(NULL, E_WARNING, "The pair level " ZEND_LONG_FMT "/type " ZEND_LONG_FMT " is " "not supported by PHP", level, type); return; } @@ -307,7 +307,7 @@ PHP_FUNCTION(socket_cmsg_space) if (entry->var_el_size > 0 && n > (zend_long)((ZEND_LONG_MAX - entry->size - CMSG_SPACE(0) - 15L) / entry->var_el_size)) { /* the -15 is to account for any padding CMSG_SPACE may add after the data */ - php_error_docref0(NULL, E_WARNING, "The value for the " + php_error_docref(NULL, E_WARNING, "The value for the " "third argument (" ZEND_LONG_FMT ") is too large", n); return; } @@ -331,7 +331,7 @@ int php_do_setsockopt_ipv6_rfc3542(php_socket *php_sock, int level, int optname, case IPV6_PKTINFO: #ifdef PHP_WIN32 if (Z_TYPE_P(arg4) == IS_ARRAY) { - php_error_docref0(NULL, E_WARNING, "Windows does not " + php_error_docref(NULL, E_WARNING, "Windows does not " "support sticky IPV6_PKTINFO"); return FAILURE; } else { diff --git a/ext/standard/html.c b/ext/standard/html.c index 0de4679788..a724338e4a 100644 --- a/ext/standard/html.c +++ b/ext/standard/html.c @@ -1187,7 +1187,7 @@ PHPAPI zend_string *php_escape_html_entities_ex(unsigned char *old, size_t oldle if (all) { /* replace with all named entities */ if (CHARSET_PARTIAL_SUPPORT(charset)) { - php_error_docref0(NULL, E_STRICT, "Only basic entities " + php_error_docref(NULL, E_STRICT, "Only basic entities " "substitution is supported for multi-byte encodings other than UTF-8; " "functionality is equivalent to htmlspecialchars"); } diff --git a/main/main.c b/main/main.c index 18d0b43d36..48e0e1a7f7 100644 --- a/main/main.c +++ b/main/main.c @@ -1163,9 +1163,9 @@ PHPAPI ZEND_COLD void php_verror(const char *docref, const char *params, int typ } /* }}} */ -/* {{{ php_error_docref0 */ -/* See: CODING_STANDARDS.md for details. */ -PHPAPI ZEND_COLD void php_error_docref0(const char *docref, int type, const char *format, ...) +/* {{{ php_error_docref */ +/* Generate an error which links to docref or the php.net documentation if docref is NULL */ +PHPAPI ZEND_COLD void php_error_docref(const char *docref, int type, const char *format, ...) { va_list args; diff --git a/main/php.h b/main/php.h index 4bc054539c..f8b1a3ca8e 100644 --- a/main/php.h +++ b/main/php.h @@ -339,7 +339,7 @@ static inline ZEND_ATTRIBUTE_DEPRECATED void php_std_error_handling() {} PHPAPI ZEND_COLD void php_verror(const char *docref, const char *params, int type, const char *format, va_list args) PHP_ATTRIBUTE_FORMAT(printf, 4, 0); /* PHPAPI void php_error(int type, const char *format, ...); */ -PHPAPI ZEND_COLD void php_error_docref0(const char *docref, int type, const char *format, ...) +PHPAPI ZEND_COLD void php_error_docref(const char *docref, int type, const char *format, ...) PHP_ATTRIBUTE_FORMAT(printf, 3, 4); PHPAPI ZEND_COLD void php_error_docref1(const char *docref, const char *param1, int type, const char *format, ...) PHP_ATTRIBUTE_FORMAT(printf, 4, 5); @@ -350,8 +350,6 @@ PHPAPI ZEND_COLD void php_win32_docref2_from_error(DWORD error, const char *para #endif END_EXTERN_C() -#define php_error_docref php_error_docref0 - #define zenderror phperror #define zendlex phplex -- 2.40.0