From 1bd3cb201983859d86d644eef9e98cd3e9de7261 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Wed, 24 Feb 2021 12:27:31 +0100 Subject: [PATCH] patch 8.2.2549: crash after using "g:" in a for loop Problem: Crash after using "g:" in a for loop. Solution: Increment the reference count. (closes #7892) --- src/testdir/test_vim9_expr.vim | 6 ++++++ src/version.c | 2 ++ src/vim9execute.c | 1 + 3 files changed, 9 insertions(+) diff --git a/src/testdir/test_vim9_expr.vim b/src/testdir/test_vim9_expr.vim index 3e69a0dd4..cda1ffdb4 100644 --- a/src/testdir/test_vim9_expr.vim +++ b/src/testdir/test_vim9_expr.vim @@ -2545,6 +2545,12 @@ def Test_expr7_namespace() assert_equal('some', get(t:, 'some_var', 'xxx')) assert_equal('xxx', get(t:, 'no_var', 'xxx')) unlet t:some_var + + # check using g: in a for loop more than DO_NOT_FREE_CNT times + for i in range(100000) + if has_key(g:, 'does-not-exist') + endif + endfor enddef def Test_expr7_parens() diff --git a/src/version.c b/src/version.c index 3d52e4967..ff8264551 100644 --- a/src/version.c +++ b/src/version.c @@ -750,6 +750,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 2549, /**/ 2548, /**/ diff --git a/src/vim9execute.c b/src/vim9execute.c index 232f0471e..e20c71105 100644 --- a/src/vim9execute.c +++ b/src/vim9execute.c @@ -1771,6 +1771,7 @@ call_def_function( tv->v_type = VAR_DICT; tv->v_lock = 0; tv->vval.v_dict = d; + ++d->dv_refcount; ++ectx.ec_stack.ga_len; } break; -- 2.50.1