From 1b8a46d59734a77cd1f5ffcf3bdfcaafd58a87e7 Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Mon, 17 Jun 2019 16:58:32 +0300 Subject: [PATCH] bpo-35431: Test math.comb() and math.perm() for OverflowError only on CPython. (GH-14146) Other implementation can raise MemoryError, but it can takes hours. --- Lib/test/test_math.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Lib/test/test_math.py b/Lib/test/test_math.py index f25913941b..fa690441be 100644 --- a/Lib/test/test_math.py +++ b/Lib/test/test_math.py @@ -525,7 +525,7 @@ class MathTests(unittest.TestCase): # Other implementations may place different upper bounds. @support.cpython_only def testFactorialHugeInputs(self): - # Currently raises ValueError for inputs that are too large + # Currently raises OverflowError for inputs that are too large # to fit into a C long. self.assertRaises(OverflowError, math.factorial, 10**100) with self.assertWarns(DeprecationWarning): @@ -1922,7 +1922,8 @@ class IsCloseTests(unittest.TestCase): self.assertEqual(perm(n, 0), 1) self.assertEqual(perm(n, 1), n) self.assertEqual(perm(n, 2), n * (n-1)) - self.assertRaises((OverflowError, MemoryError), perm, n, n) + if support.check_impl_detail(cpython=True): + self.assertRaises(OverflowError, perm, n, n) for n, k in (True, True), (True, False), (False, False): self.assertEqual(perm(n, k), 1) @@ -1991,7 +1992,8 @@ class IsCloseTests(unittest.TestCase): self.assertEqual(comb(n, n), 1) self.assertEqual(comb(n, n-1), n) self.assertEqual(comb(n, n-2), n * (n-1) // 2) - self.assertRaises((OverflowError, MemoryError), comb, n, n//2) + if support.check_impl_detail(cpython=True): + self.assertRaises(OverflowError, comb, n, n//2) for n, k in (True, True), (True, False), (False, False): self.assertEqual(comb(n, k), 1) -- 2.40.0