From 1b5632445be2dba6c66162749cc8bbf8dff887d1 Mon Sep 17 00:00:00 2001 From: Raymond Hettinger Date: Thu, 14 Feb 2008 09:32:45 +0000 Subject: [PATCH] Add diagnostic message to help figure-out why SocketServer tests occasionally crash when trying to remove a pid that in not in the activechildren list. --- Lib/SocketServer.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Lib/SocketServer.py b/Lib/SocketServer.py index 2eed914492..1763c1d5e4 100644 --- a/Lib/SocketServer.py +++ b/Lib/SocketServer.py @@ -452,7 +452,11 @@ class ForkingMixIn: except os.error: pid = None if not pid: break - self.active_children.remove(pid) + try: + self.active_children.remove(pid) + except ValueError, e: + raise ValueError('%s. x=%d and list=%r' % (e.message, pid, + self.active_children)) def handle_timeout(self): """Wait for zombies after self.timeout seconds of inactivity. -- 2.50.0