From 1ac65e8983220569da42e5f0ff02a48c9a751eb0 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Sun, 14 Apr 2019 04:20:42 +0000 Subject: [PATCH] [X86] Update bool_reduction_v8f32 test cases from vector-compare-any_of.ll and vector-compare-all_of.ll to be proper reductions. One of the shuffles was used twice. While the intended shuffle wasn't connected. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@358346 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/CodeGen/X86/vector-compare-all_of.ll | 32 +++++++++------------- test/CodeGen/X86/vector-compare-any_of.ll | 33 ++++++++++------------- 2 files changed, 27 insertions(+), 38 deletions(-) diff --git a/test/CodeGen/X86/vector-compare-all_of.ll b/test/CodeGen/X86/vector-compare-all_of.ll index 60b994b66fe..e79c01f43b3 100644 --- a/test/CodeGen/X86/vector-compare-all_of.ll +++ b/test/CodeGen/X86/vector-compare-all_of.ll @@ -1043,27 +1043,18 @@ define i1 @bool_reduction_v8f32(<8 x float> %x, <8 x float> %y) { ; SSE-NEXT: cmpneqps %xmm3, %xmm1 ; SSE-NEXT: cmpneqps %xmm2, %xmm0 ; SSE-NEXT: packssdw %xmm1, %xmm0 -; SSE-NEXT: pshufd {{.*#+}} xmm1 = xmm0[2,3,0,1] -; SSE-NEXT: pand %xmm0, %xmm1 -; SSE-NEXT: pshufd {{.*#+}} xmm0 = xmm1[1,1,2,3] -; SSE-NEXT: pand %xmm0, %xmm1 -; SSE-NEXT: pand %xmm0, %xmm1 -; SSE-NEXT: pextrb $0, %xmm1, %eax -; SSE-NEXT: # kill: def $al killed $al killed $eax +; SSE-NEXT: packsswb %xmm0, %xmm0 +; SSE-NEXT: pmovmskb %xmm0, %eax +; SSE-NEXT: cmpb $-1, %al +; SSE-NEXT: sete %al ; SSE-NEXT: retq ; ; AVX-LABEL: bool_reduction_v8f32: ; AVX: # %bb.0: ; AVX-NEXT: vcmpneqps %ymm1, %ymm0, %ymm0 -; AVX-NEXT: vextractf128 $1, %ymm0, %xmm1 -; AVX-NEXT: vpackssdw %xmm1, %xmm0, %xmm0 -; AVX-NEXT: vpshufd {{.*#+}} xmm1 = xmm0[2,3,0,1] -; AVX-NEXT: vpand %xmm0, %xmm1, %xmm0 -; AVX-NEXT: vpshufd {{.*#+}} xmm1 = xmm0[1,1,2,3] -; AVX-NEXT: vpand %xmm1, %xmm0, %xmm0 -; AVX-NEXT: vpand %xmm0, %xmm1, %xmm0 -; AVX-NEXT: vpextrb $0, %xmm0, %eax -; AVX-NEXT: # kill: def $al killed $al killed $eax +; AVX-NEXT: vmovmskps %ymm0, %eax +; AVX-NEXT: cmpb $-1, %al +; AVX-NEXT: sete %al ; AVX-NEXT: vzeroupper ; AVX-NEXT: retq ; @@ -1075,10 +1066,13 @@ define i1 @bool_reduction_v8f32(<8 x float> %x, <8 x float> %y) { ; AVX512-NEXT: vextracti128 $1, %ymm1, %xmm1 ; AVX512-NEXT: vpslld $31, %ymm1, %ymm1 ; AVX512-NEXT: vptestmd %ymm1, %ymm1, %k1 {%k1} +; AVX512-NEXT: vmovdqa32 %ymm0, %ymm1 {%k1} {z} +; AVX512-NEXT: vpshufd {{.*#+}} xmm1 = xmm1[2,3,0,1] +; AVX512-NEXT: vpslld $31, %ymm1, %ymm1 +; AVX512-NEXT: vptestmd %ymm1, %ymm1, %k1 {%k1} ; AVX512-NEXT: vmovdqa32 %ymm0, %ymm0 {%k1} {z} -; AVX512-NEXT: vpshufd {{.*#+}} xmm0 = xmm0[2,3,0,1] +; AVX512-NEXT: vpshufd {{.*#+}} xmm0 = xmm0[1,1,2,3] ; AVX512-NEXT: vpslld $31, %ymm0, %ymm0 -; AVX512-NEXT: vptestmd %ymm0, %ymm0, %k1 {%k1} ; AVX512-NEXT: vptestmd %ymm0, %ymm0, %k0 {%k1} ; AVX512-NEXT: kmovd %k0, %eax ; AVX512-NEXT: # kill: def $al killed $al killed $eax @@ -1090,7 +1084,7 @@ define i1 @bool_reduction_v8f32(<8 x float> %x, <8 x float> %y) { %s2 = shufflevector <8 x i1> %b, <8 x i1> undef, <8 x i32> %c = and <8 x i1> %s2, %b %s3 = shufflevector <8 x i1> %c, <8 x i1> undef, <8 x i32> - %d = and <8 x i1> %s2, %c + %d = and <8 x i1> %s3, %c %e = extractelement <8 x i1> %d, i32 0 ret i1 %e } diff --git a/test/CodeGen/X86/vector-compare-any_of.ll b/test/CodeGen/X86/vector-compare-any_of.ll index c0d3d740098..b5261096fbf 100644 --- a/test/CodeGen/X86/vector-compare-any_of.ll +++ b/test/CodeGen/X86/vector-compare-any_of.ll @@ -968,27 +968,18 @@ define i1 @bool_reduction_v8f32(<8 x float> %x, <8 x float> %y) { ; SSE-NEXT: cmpneqps %xmm3, %xmm1 ; SSE-NEXT: cmpneqps %xmm2, %xmm0 ; SSE-NEXT: packssdw %xmm1, %xmm0 -; SSE-NEXT: pshufd {{.*#+}} xmm1 = xmm0[2,3,0,1] -; SSE-NEXT: por %xmm0, %xmm1 -; SSE-NEXT: pshufd {{.*#+}} xmm0 = xmm1[1,1,2,3] -; SSE-NEXT: por %xmm0, %xmm1 -; SSE-NEXT: por %xmm0, %xmm1 -; SSE-NEXT: pextrb $0, %xmm1, %eax -; SSE-NEXT: # kill: def $al killed $al killed $eax +; SSE-NEXT: packsswb %xmm0, %xmm0 +; SSE-NEXT: pmovmskb %xmm0, %eax +; SSE-NEXT: testb %al, %al +; SSE-NEXT: setne %al ; SSE-NEXT: retq ; ; AVX-LABEL: bool_reduction_v8f32: ; AVX: # %bb.0: ; AVX-NEXT: vcmpneqps %ymm1, %ymm0, %ymm0 -; AVX-NEXT: vextractf128 $1, %ymm0, %xmm1 -; AVX-NEXT: vpackssdw %xmm1, %xmm0, %xmm0 -; AVX-NEXT: vpshufd {{.*#+}} xmm1 = xmm0[2,3,0,1] -; AVX-NEXT: vpor %xmm0, %xmm1, %xmm0 -; AVX-NEXT: vpshufd {{.*#+}} xmm1 = xmm0[1,1,2,3] -; AVX-NEXT: vpor %xmm1, %xmm0, %xmm0 -; AVX-NEXT: vpor %xmm0, %xmm1, %xmm0 -; AVX-NEXT: vpextrb $0, %xmm0, %eax -; AVX-NEXT: # kill: def $al killed $al killed $eax +; AVX-NEXT: vmovmskps %ymm0, %eax +; AVX-NEXT: testb %al, %al +; AVX-NEXT: setne %al ; AVX-NEXT: vzeroupper ; AVX-NEXT: retq ; @@ -1001,11 +992,15 @@ define i1 @bool_reduction_v8f32(<8 x float> %x, <8 x float> %y) { ; AVX512-NEXT: vpslld $31, %ymm1, %ymm1 ; AVX512-NEXT: vptestmd %ymm1, %ymm1, %k0 ; AVX512-NEXT: korw %k1, %k0, %k1 +; AVX512-NEXT: vmovdqa32 %ymm0, %ymm1 {%k1} {z} +; AVX512-NEXT: vpshufd {{.*#+}} xmm1 = xmm1[2,3,0,1] +; AVX512-NEXT: vpslld $31, %ymm1, %ymm1 +; AVX512-NEXT: vptestmd %ymm1, %ymm1, %k0 +; AVX512-NEXT: korw %k1, %k0, %k1 ; AVX512-NEXT: vmovdqa32 %ymm0, %ymm0 {%k1} {z} -; AVX512-NEXT: vpshufd {{.*#+}} xmm0 = xmm0[2,3,0,1] +; AVX512-NEXT: vpshufd {{.*#+}} xmm0 = xmm0[1,1,2,3] ; AVX512-NEXT: vpslld $31, %ymm0, %ymm0 ; AVX512-NEXT: vptestmd %ymm0, %ymm0, %k0 -; AVX512-NEXT: korw %k1, %k0, %k1 ; AVX512-NEXT: korw %k1, %k0, %k0 ; AVX512-NEXT: kmovd %k0, %eax ; AVX512-NEXT: # kill: def $al killed $al killed $eax @@ -1017,7 +1012,7 @@ define i1 @bool_reduction_v8f32(<8 x float> %x, <8 x float> %y) { %s2 = shufflevector <8 x i1> %b, <8 x i1> undef, <8 x i32> %c = or <8 x i1> %s2, %b %s3 = shufflevector <8 x i1> %c, <8 x i1> undef, <8 x i32> - %d = or <8 x i1> %s2, %c + %d = or <8 x i1> %s3, %c %e = extractelement <8 x i1> %d, i32 0 ret i1 %e } -- 2.50.1