From 194577d7a62a37ee3c562ac3def67cd7e2085cad Mon Sep 17 00:00:00 2001 From: Derick Rethans Date: Wed, 8 Oct 2008 09:44:12 +0000 Subject: [PATCH] - Fixed mime-type generation. #- Charset markers need to be prepended with ; -- the tests were also wrong. --- ext/fileinfo/libmagic/ascmagic.c | 2 +- ext/fileinfo/tests/finfo_buffer_basic.phpt | 10 +++++----- ext/fileinfo/tests/finfo_buffer_variation1.phpt | 10 +++++----- ext/fileinfo/tests/finfo_file_basic.phpt | 4 ++-- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/ext/fileinfo/libmagic/ascmagic.c b/ext/fileinfo/libmagic/ascmagic.c index cb39f69087..c25d81aa65 100644 --- a/ext/fileinfo/libmagic/ascmagic.c +++ b/ext/fileinfo/libmagic/ascmagic.c @@ -264,7 +264,7 @@ subtype_identified: if ((mime == 0 || mime == MAGIC_MIME) && code_mime) { if ((mime & MAGIC_MIME_TYPE) && - file_printf(ms, " charset=") == -1) + file_printf(ms, "; charset=") == -1) goto done; if (file_printf(ms, code_mime) == -1) goto done; diff --git a/ext/fileinfo/tests/finfo_buffer_basic.phpt b/ext/fileinfo/tests/finfo_buffer_basic.phpt index eaef80c63a..7bc10c2724 100644 --- a/ext/fileinfo/tests/finfo_buffer_basic.phpt +++ b/ext/fileinfo/tests/finfo_buffer_basic.phpt @@ -44,10 +44,10 @@ string(22) "old ACE/gr binary file" string(12) "xo65 object," string(15) "MIFF image data" string(25) "RIFF (little-endian) data" -string(27) "text/plain charset=us-ascii" -string(25) "text/plain charset=ebcdic" +string(28) "text/plain; charset=us-ascii" +string(26) "text/plain; charset=ebcdic" string(24) "application/octet-stream" -string(27) "text/plain charset=us-ascii" -string(27) "text/plain charset=us-ascii" -string(29) "text/plain charset=iso-8859-1" +string(28) "text/plain; charset=us-ascii" +string(28) "text/plain; charset=us-ascii" +string(30) "text/plain; charset=iso-8859-1" ===DONE=== diff --git a/ext/fileinfo/tests/finfo_buffer_variation1.phpt b/ext/fileinfo/tests/finfo_buffer_variation1.phpt index c2a6f1d12b..7616c6c789 100644 --- a/ext/fileinfo/tests/finfo_buffer_variation1.phpt +++ b/ext/fileinfo/tests/finfo_buffer_variation1.phpt @@ -43,10 +43,10 @@ string(22) "old ACE/gr binary file" string(12) "xo65 object," string(15) "MIFF image data" string(25) "RIFF (little-endian) data" -string(27) "text/plain charset=us-ascii" -string(25) "text/plain charset=ebcdic" +string(28) "text/plain; charset=us-ascii" +string(26) "text/plain; charset=ebcdic" string(24) "application/octet-stream" -string(27) "text/plain charset=us-ascii" -string(27) "text/plain charset=us-ascii" -string(29) "text/plain charset=iso-8859-1" +string(28) "text/plain; charset=us-ascii" +string(28) "text/plain; charset=us-ascii" +string(30) "text/plain; charset=iso-8859-1" ===DONE=== diff --git a/ext/fileinfo/tests/finfo_file_basic.phpt b/ext/fileinfo/tests/finfo_file_basic.phpt index 6ac988450b..33258dbaaf 100644 --- a/ext/fileinfo/tests/finfo_file_basic.phpt +++ b/ext/fileinfo/tests/finfo_file_basic.phpt @@ -22,7 +22,7 @@ var_dump( finfo_file( $finfo, $magicFile ) ); ===DONE=== --EXPECTF-- *** Testing finfo_file() : basic functionality *** -string(25) "text/x-c charset=us-ascii" +string(26) "text/x-c; charset=us-ascii" string(15) "PHP script text" -string(26) "text/plain charset=unknown" +string(27) "text/plain; charset=unknown" ===DONE=== -- 2.40.0