From 1943349b126ed6d91c680c0f53b2559adef12f9f Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Fri, 4 Jan 2019 13:48:58 +0000 Subject: [PATCH] [gn build] Make write_cmake_config.py check that each key passed is unique I got that wrong once while locally while working on check-llvm. Reviewed as part of https://reviews.llvm.org/D56195 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@350394 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/gn/build/write_cmake_config.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/utils/gn/build/write_cmake_config.py b/utils/gn/build/write_cmake_config.py index 7fa853d4147..0f476542ef6 100755 --- a/utils/gn/build/write_cmake_config.py +++ b/utils/gn/build/write_cmake_config.py @@ -53,6 +53,9 @@ def main(): values = {} for value in args.values: key, val = value.split('=', 1) + if key in values: + print('duplicate key "%s" in args' % key, file=sys.stderr) + return 1 values[key] = val.replace('\\n', '\n') unused_values = set(values.keys()) -- 2.50.1