From 1671c01650d2cf9398b2e5ff87be2e2fd03781b7 Mon Sep 17 00:00:00 2001 From: Teodor Sigaev Date: Mon, 9 Apr 2018 09:19:09 +0300 Subject: [PATCH] Remove repeated test in contrib/amcheck Repeating these tests adds unnecessary cycles, since no improvement in test coverage is expected. Cleanup from commit 8224de4f42ccf98e08db07b43d52fed72f962ebb. Peter Geoghegan --- contrib/amcheck/expected/check_btree.out | 20 +------------------- contrib/amcheck/sql/check_btree.sql | 6 +----- 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/contrib/amcheck/expected/check_btree.out b/contrib/amcheck/expected/check_btree.out index 2a06cce9a0..ed80ac4664 100644 --- a/contrib/amcheck/expected/check_btree.out +++ b/contrib/amcheck/expected/check_btree.out @@ -111,27 +111,9 @@ SELECT bt_index_parent_check('bttest_multi_idx', true); (1 row) -SELECT bt_index_parent_check('bttest_multi_idx', true); - bt_index_parent_check ------------------------ - -(1 row) - --- repeat same checks with index made by insertions +-- repeat expansive test for index built using insertions TRUNCATE bttest_multi; INSERT INTO bttest_multi SELECT i, i%2 FROM generate_series(1, 100000) as i; -SELECT bt_index_check('bttest_multi_idx'); - bt_index_check ----------------- - -(1 row) - -SELECT bt_index_parent_check('bttest_multi_idx', true); - bt_index_parent_check ------------------------ - -(1 row) - SELECT bt_index_parent_check('bttest_multi_idx', true); bt_index_parent_check ----------------------- diff --git a/contrib/amcheck/sql/check_btree.sql b/contrib/amcheck/sql/check_btree.sql index da2f1314e5..4ca9d2d0ed 100644 --- a/contrib/amcheck/sql/check_btree.sql +++ b/contrib/amcheck/sql/check_btree.sql @@ -65,15 +65,11 @@ COMMIT; SELECT bt_index_check('bttest_multi_idx'); -- more expansive test for index with included columns SELECT bt_index_parent_check('bttest_multi_idx', true); -SELECT bt_index_parent_check('bttest_multi_idx', true); --- repeat same checks with index made by insertions +-- repeat expansive test for index built using insertions TRUNCATE bttest_multi; INSERT INTO bttest_multi SELECT i, i%2 FROM generate_series(1, 100000) as i; -SELECT bt_index_check('bttest_multi_idx'); SELECT bt_index_parent_check('bttest_multi_idx', true); -SELECT bt_index_parent_check('bttest_multi_idx', true); - -- cleanup DROP TABLE bttest_a; -- 2.40.0