From 16183631ede0656a5cfd58626419cc081d281fff Mon Sep 17 00:00:00 2001 From: Georg Brandl Date: Fri, 4 Aug 2006 18:07:34 +0000 Subject: [PATCH] Better fix for bug #1531405, not executing str(value) twice. --- Lib/traceback.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Lib/traceback.py b/Lib/traceback.py index 505a3052cc..75e1fcffa3 100644 --- a/Lib/traceback.py +++ b/Lib/traceback.py @@ -202,15 +202,11 @@ def format_exception_only(etype, value): def _format_final_exc_line(etype, value): """Return a list of a single line -- normal case for format_exception_only""" - try: - printable = value is None or not str(value) - except: - printable = False - - if printable: + valuestr = _some_str(value) + if value is None or not valuestr: line = "%s\n" % etype else: - line = "%s: %s\n" % (etype, _some_str(value)) + line = "%s: %s\n" % (etype, valuestr) return line def _some_str(value): -- 2.50.1