From 152fbe88e9fd661c195b2374a0d229998e18e8dc Mon Sep 17 00:00:00 2001 From: Barry Warsaw Date: Fri, 18 Aug 2000 05:09:50 +0000 Subject: [PATCH] pattern_findall(): Plug small memory leak discovered by Insure. PyList_Append() always incref's the inserted item. Be sure to decref it regardless of whether the append succeeds or fails. --- Modules/_sre.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Modules/_sre.c b/Modules/_sre.c index 29e92ac574..3b78fb97e8 100644 --- a/Modules/_sre.c +++ b/Modules/_sre.c @@ -1698,10 +1698,10 @@ pattern_findall(PatternObject* self, PyObject* args) break; } - if (PyList_Append(list, item) < 0) { - Py_DECREF(item); + status = PyList_Append(list, item); + Py_DECREF(item); + if (status < 0) goto error; - } if (state.ptr == state.start) state.start = (void*) ((char*) state.ptr + state.charsize); -- 2.49.0