From 150a741fee1fee325be80c12c34ee47c55a6b79c Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 9 Nov 2010 14:53:23 +0000 Subject: [PATCH] Fix bug #53279 (SplFileObject doesn't initialise default CSV escape character). --- ext/spl/spl_directory.c | 1 + .../SplFileObject_fgetcsv_escape_default.phpt | 24 +++++++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 ext/spl/tests/SplFileObject_fgetcsv_escape_default.phpt diff --git a/ext/spl/spl_directory.c b/ext/spl/spl_directory.c index d02a95b59d..0d6cfa269e 100755 --- a/ext/spl/spl_directory.c +++ b/ext/spl/spl_directory.c @@ -274,6 +274,7 @@ static int spl_filesystem_file_open(spl_filesystem_object *intern, int use_inclu intern->u.file.delimiter = ','; intern->u.file.enclosure = '"'; + intern->u.file.escape = '\\'; zend_hash_find(&intern->std.ce->function_table, "getcurrentline", sizeof("getcurrentline"), (void **) &intern->u.file.func_getCurr); diff --git a/ext/spl/tests/SplFileObject_fgetcsv_escape_default.phpt b/ext/spl/tests/SplFileObject_fgetcsv_escape_default.phpt new file mode 100644 index 0000000000..b3b6c7c609 --- /dev/null +++ b/ext/spl/tests/SplFileObject_fgetcsv_escape_default.phpt @@ -0,0 +1,24 @@ +--TEST-- +SplFileObject::fgetcsv with default escape character +--FILE-- +fgetcsv()); +?> +--CLEAN-- + +--EXPECTF-- +array(3) { + [0]=> + string(4) "aa\"" + [1]=> + string(2) "bb" + [2]=> + string(3) "\"c" +} -- 2.50.1