From 148f1f7936afd718bac7be95089e77673e43f16f Mon Sep 17 00:00:00 2001 From: Peter Collingbourne Date: Sun, 20 Mar 2011 08:06:45 +0000 Subject: [PATCH] Only objects are declared const by a constexpr specifier, per C++0x [dcl.constexpr]p9 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@127967 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaType.cpp | 6 ++++-- test/SemaCXX/cxx0x-constexpr-const.cpp | 10 ++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) create mode 100644 test/SemaCXX/cxx0x-constexpr-const.cpp diff --git a/lib/Sema/SemaType.cpp b/lib/Sema/SemaType.cpp index dc2d3ac518..88541c9508 100644 --- a/lib/Sema/SemaType.cpp +++ b/lib/Sema/SemaType.cpp @@ -2116,8 +2116,10 @@ TypeSourceInfo *Sema::GetTypeForDeclarator(Declarator &D, Scope *S, // Diagnose any ignored type attributes. if (!T.isNull()) state.diagnoseIgnoredTypeAttrs(T); - // If there's a constexpr specifier, treat it as a top-level const. - if (D.getDeclSpec().isConstexprSpecified()) { + // C++0x [dcl.constexpr]p9: + // A constexpr specifier used in an object declaration declares the object + // as const. + if (D.getDeclSpec().isConstexprSpecified() && T->isObjectType()) { T.addConst(); } diff --git a/test/SemaCXX/cxx0x-constexpr-const.cpp b/test/SemaCXX/cxx0x-constexpr-const.cpp new file mode 100644 index 0000000000..79e6dda3e1 --- /dev/null +++ b/test/SemaCXX/cxx0x-constexpr-const.cpp @@ -0,0 +1,10 @@ +// RUN: %clang_cc1 -std=c++0x -fsyntax-only -verify %s + +constexpr int x = 1; +constexpr int id(int x) { return x; } + +void foo(void) { + x = 2; // expected-error {{read-only variable is not assignable}} + int (*idp)(int) = id; +} + -- 2.50.1